linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [RFC PATCH] nvme-pci: Bounce buffer for interleaved metadata
Date: Wed, 28 Feb 2018 09:35:11 -0700	[thread overview]
Message-ID: <20180228163510.GC16002@localhost.localdomain> (raw)
In-Reply-To: <yq17eqx4w64.fsf@oracle.com>

On Tue, Feb 27, 2018@10:42:27PM -0500, Martin K. Petersen wrote:
> > On the other hand, I get the impression some people requesting this
> > may think their application will get to access the extended LBAs. The
> > reality is the kernel owns the metadata, so I may just setting myself
> > up to explain why "fdisk" still shows a 512b format instead of 520b...
> 
> The whole point of DIF (over using regular 520 or 528 byte sectors) was
> to keep the logical block size at 512 and not deal with the PI in the
> data buffers.
> 
> And the point of defining DIX was to avoid having to do what your patch
> is doing.

Right, this RFC is just about enabling formats that don't subscribe to
the DIX format. It turns out some people believe those extended LBAs
are useful for something.

I still think this LBA format is not a good fit for this driver, but
I'd like to not push people to use out-of-tree or user space drivers
if there is a reasonable way to accommodate here. The driver's existing
NVMe IO passthrough makes this format reachable already, but there is
resistance to use the ioctl over more standard read/write paths.

  reply	other threads:[~2018-02-28 16:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24  0:05 [RFC PATCH] nvme-pci: Bounce buffer for interleaved metadata Keith Busch
2018-02-25 17:30 ` Sagi Grimberg
2018-02-26 16:49   ` Keith Busch
2018-02-28  3:46   ` Martin K. Petersen
2018-03-01  9:22     ` Sagi Grimberg
2018-02-28  3:42 ` Martin K. Petersen
2018-02-28 16:35   ` Keith Busch [this message]
2018-02-28 16:37     ` Christoph Hellwig
2018-02-28 19:54       ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180228163510.GC16002@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).