From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V3] nvme-pci: assign separate irq vectors for adminq and ioq1
Date: Tue, 13 Mar 2018 11:40:53 -0600 [thread overview]
Message-ID: <20180313174052.GJ18494@localhost.localdomain> (raw)
In-Reply-To: <20180313104452.GA8782@ming.t460p>
On Tue, Mar 13, 2018@06:45:00PM +0800, Ming Lei wrote:
> On Tue, Mar 13, 2018@05:58:08PM +0800, Jianchao Wang wrote:
> > Currently, adminq and ioq1 share the same irq vector which is set
> > affinity to cpu0. If a system allows cpu0 to be offlined, the adminq
> > will not be able work any more.
> >
> > To fix this, assign separate irq vectors for adminq and ioq1. Set
> > .pre_vectors == 1 when allocate irq vectors, then assign the first
> > one to adminq which will have affinity cpumask with all possible
> > cpus. On the other hand, if controller has only legacy or single
> > -message MSI, we will setup adminq and 1 ioq and let them share
> > the only one irq vector.
> >
> > Signed-off-by: Jianchao Wang <jianchao.w.wang at oracle.com>
>
> Reviewed-by: Ming Lei <ming.lei at redhat.com>
Thanks, applied with an updated changelog.
Not being able to use the admin queue is a pretty big deal, so it's pushed
to the next nvme 4.16-rc branch. This may even be good stable material.
prev parent reply other threads:[~2018-03-13 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 9:58 [PATCH V3] nvme-pci: assign separate irq vectors for adminq and ioq1 Jianchao Wang
2018-03-13 10:45 ` Ming Lei
2018-03-13 17:40 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313174052.GJ18494@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox