From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme_fc: io timeout should defer abort to ctrl reset
Date: Thu, 15 Mar 2018 14:29:31 -0600 [thread overview]
Message-ID: <20180315202930.GD30695@localhost.localdomain> (raw)
In-Reply-To: <20180312163222.23043-1-jsmart2021@gmail.com>
On Mon, Mar 12, 2018@09:32:22AM -0700, James Smart wrote:
> The current nvme_fc code, when an io times out, will abort the io
> on the fc link, then call the error recovery routine to reset the
> controller. It is during the reset of the controller that the
> transport will wait for all ios to be aborted before sending a
> Disconnect LS to the target.
>
> However, the reset routine only waits for the io which it generates
> the abort for to complete. Any io that was aborted just prior to the
> reset isn't in it's list to wait for. Thus the Disconnect is getting
> sent before the aborts have completed.
>
> Correct by removing the abort in the timeout handler. The reset will
> generate the abort. At that point the timeout handler can be simplified
> to request the reset (via the error handler) and restart the timeout
> timer.
>
> Also fixes a small typo in a comment in the reset handler.
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
This sounds right to me despite being less familiar with the nvme-fc
portion, and applied for 4.17.
prev parent reply other threads:[~2018-03-15 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 16:32 [PATCH] nvme_fc: io timeout should defer abort to ctrl reset James Smart
2018-03-15 20:29 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315202930.GD30695@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox