From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 4/3 rfc nvmetcli] nvmetcli: expose nvmet port status and state
Date: Thu, 22 Mar 2018 21:03:03 +0200 [thread overview]
Message-ID: <20180322190303.10951-5-sagi@grimberg.me> (raw)
In-Reply-To: <20180322190303.10951-1-sagi@grimberg.me>
status reflects if any subsystems are bound and can
accept existing connections. state reflects the
physical state of the port.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
nvmetcli | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/nvmetcli b/nvmetcli
index 6b102a235450..86f7c01708cb 100755
--- a/nvmetcli
+++ b/nvmetcli
@@ -388,7 +388,14 @@ class UIPortNode(UINode):
if trsvcid != "none":
info.append("trsvcid=%s" % trsvcid)
enabled = not (not self.cfnode.subsystems and not list(self.cfnode.referrals))
- return (", ".join(info), True if enabled else 0)
+ info.append("status=" + ("enabled" if enabled else "disabled"))
+ if not enabled:
+ ret = 0
+ else:
+ active = not (not int(self.cfnode.get_attr("addr", "tractive")))
+ info.append("state=" + ("up" if active else "down"))
+ ret = True if active else False
+ return (", ".join(info), ret)
class UIPortSubsystemsNode(UINode):
def __init__(self, parent):
--
2.14.1
next prev parent reply other threads:[~2018-03-22 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 19:02 [PATCH rfc 0/3] nvmet-rdma automatic port re-activation Sagi Grimberg
2018-03-22 19:03 ` [PATCH rfc 1/3] nvmet-rdma: automatic listening " Sagi Grimberg
2018-03-25 8:25 ` Max Gurtovoy
2018-03-26 7:01 ` Max Gurtovoy
2018-04-04 13:06 ` Sagi Grimberg
2018-03-22 19:03 ` [PATCH rfc 2/3] nvmet: Add fabrics ops to port Sagi Grimberg
2018-03-22 19:03 ` [PATCH rfc 3/3] nvmet: Add port transport active flag Sagi Grimberg
2018-03-26 7:52 ` Max Gurtovoy
2018-04-04 13:08 ` Sagi Grimberg
2018-03-22 19:03 ` Sagi Grimberg [this message]
2018-03-27 8:34 ` [PATCH 4/3 rfc nvmetcli] nvmetcli: expose nvmet port status and state Nitzan Carmi
2018-04-11 16:17 ` [PATCH rfc 0/3] nvmet-rdma automatic port re-activation Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322190303.10951-5-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox