From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v2] nvme: expand nvmf_check_if_ready checks
Date: Wed, 28 Mar 2018 01:31:36 -0700 [thread overview]
Message-ID: <20180328083136.GC31409@infradead.org> (raw)
In-Reply-To: <20180327230724.25843-1-jsmart2021@gmail.com>
> +static inline blk_status_t nvmf_check_if_ready(struct nvme_ctrl *ctrl,
> + struct request *rq, bool qlive, bool connectivity)
Please rename qlive to queue_live and explain what connectivity means.
Maye this should be is_connected? How do we get a command on a not
conected queue?
Also I think the function is large enough now to move out of line.
next prev parent reply other threads:[~2018-03-28 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 23:07 [PATCH v2] nvme: expand nvmf_check_if_ready checks James Smart
2018-03-28 8:31 ` Christoph Hellwig [this message]
2018-03-28 16:21 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328083136.GC31409@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox