From: snitzer@redhat.com (Mike Snitzer)
Subject: [PATCH v3] nvme: expand nvmf_check_if_ready checks
Date: Thu, 29 Mar 2018 20:23:38 -0400 [thread overview]
Message-ID: <20180330002337.GA8893@redhat.com> (raw)
In-Reply-To: <9bba839b-5ddd-5f8b-c8a9-b5ffc10b46b6@gmail.com>
On Thu, Mar 29 2018 at 6:13pm -0400,
James Smart <jsmart2021@gmail.com> wrote:
> Thanks... I'm not sure that this invalidates the patch, as the real
> reason for the patch is to stop the EIO cases without multipath
> where they should have been requeued - the opposite of what you
> want. I'll take a further look.
I really wasn't making any statement about the patch. Given you cc'd me
on this patch I thought it was the FAILFAST stuff we talked about last
week. So I was pointing out I'm not seeing any failfast improvement.
But I'm not confident my mptest test is completely valid... so I was
fishing for your (or others') help.
But looking closer the header does speak to honoring failfast if
present. dm-multipath does set failfast, so why wouldn't that be
applicable?
Maybe you're saying the patch is more concerned with other details but
did make some attempt to honor failfast..
Mike
next prev parent reply other threads:[~2018-03-30 0:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 20:21 [PATCH v3] nvme: expand nvmf_check_if_ready checks James Smart
2018-03-29 20:57 ` Mike Snitzer
2018-03-29 22:13 ` James Smart
2018-03-30 0:23 ` Mike Snitzer [this message]
2018-04-04 13:42 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330002337.GA8893@redhat.com \
--to=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox