From: keith.busch@intel.com (Keith Busch)
Subject: IRQ/nvme_pci_complete_rq: NULL pointer dereference yet again
Date: Fri, 6 Apr 2018 13:34:43 -0600 [thread overview]
Message-ID: <20180406193443.GM10098@localhost.localdomain> (raw)
In-Reply-To: <767385b2-41fe-8a7c-3bed-f0b51f977635@eng.utah.edu>
On Fri, Apr 06, 2018@01:00:37PM -0600, Scott Bauer wrote:
> I think we may get into a deadlock situation if we grab the pci_lock_rescan.
> the hotplug unconfigure code will eventually call driver->remove() which I believe
> can end up in the aer_remove(), which will do a flush_work. If the aer delegated
> irq handler is waiting on the pci_lock_rescan, before it does a walk_bus, we've deadlocked
> there as the hp code is waiting on the remove() to finish, and the remove is waiting on
> the flush work to finish and the work being flushed is waiting on the lock.
Darn. I believe your point is valid, though not through pciehp since
root ports themselves are not pcie hot pluggable components, but other
paths could get there.
next prev parent reply other threads:[~2018-04-06 19:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5d6d1a8c-6490-4046-0fba-da0a0df3d00c@gmail.com>
2018-04-05 21:38 ` IRQ/nvme_pci_complete_rq: NULL pointer dereference yet again Keith Busch
2018-04-05 21:22 ` Scott Bauer
2018-04-05 22:21 ` Alex G.
2018-04-05 22:41 ` Keith Busch
2018-04-05 22:48 ` Keith Busch
2018-04-05 23:05 ` Keith Busch
2018-04-05 23:39 ` Alex G.
2018-04-05 23:44 ` Alex G.
2018-04-06 15:32 ` Keith Busch
2018-04-06 15:46 ` Alex G.
[not found] ` <94d77cb7-759f-595a-2264-37305dfa96c4@gmail.com>
2018-04-06 17:16 ` Scott Bauer
2018-04-06 17:46 ` Alex G.
2018-04-06 18:04 ` Keith Busch
2018-04-06 19:00 ` Scott Bauer
2018-04-06 19:34 ` Keith Busch [this message]
2018-04-06 19:08 ` Alex G.
2018-04-06 22:00 ` Keith Busch
2018-04-09 18:23 ` Alex G.
2018-04-09 19:11 ` Keith Busch
2018-04-09 19:36 ` Alex G.
2018-04-09 19:47 ` Keith Busch
2018-04-10 0:07 ` Alex G.
2018-04-10 14:19 ` Alex G.
2018-05-02 15:39 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406193443.GM10098@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox