Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Use admin command effects for admin commands
Date: Thu, 12 Apr 2018 07:39:56 +0200	[thread overview]
Message-ID: <20180412053956.GA30003@lst.de> (raw)
In-Reply-To: <20180411204812.19131-1-keith.busch@intel.com>

On Wed, Apr 11, 2018@02:48:12PM -0600, Keith Busch wrote:
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> This was correct in the first few versions of this patch, and goofed up
> on the last one somehow. Didn't notice until I tested a drive with the
> capability today.
> 
>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good!

Btw, time to send another nvme update to Jens?

>
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b70f02bafac6..6ed91ae7f740 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1102,7 +1102,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>  	}
>  
>  	if (ctrl->effects)
> -		effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
> +		effects = le32_to_cpu(ctrl->effects->acs[opcode]);
>  	else
>  		effects = nvme_known_admin_effects(opcode);
>  
> -- 
> 2.14.3
---end quoted text---

      reply	other threads:[~2018-04-12  5:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 20:48 [PATCH] nvme: Use admin command effects for admin commands Keith Busch
2018-04-12  5:39 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180412053956.GA30003@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox