From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v1 2/3] nvmet: Add fabrics ops to port
Date: Thu, 12 Apr 2018 11:06:54 +0300 [thread overview]
Message-ID: <20180412080656.1691-3-sagi@grimberg.me> (raw)
In-Reply-To: <20180412080656.1691-1-sagi@grimberg.me>
From: Israel Rukshin <israelr@mellanox.com>
Instead of getting the nvmet_fabrics_ops from nvmet_transports array
each time we want to use it, just take it directly from the port.
Signed-off-by: Israel Rukshin <israelr at mellanox.com>
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/target/core.c | 9 ++++-----
drivers/nvme/target/nvmet.h | 1 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index e95424f172fd..e95e9cd30647 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -189,21 +189,20 @@ int nvmet_enable_port(struct nvmet_port *port)
return ret;
}
+ port->ops = ops;
port->enabled = true;
return 0;
}
void nvmet_disable_port(struct nvmet_port *port)
{
- const struct nvmet_fabrics_ops *ops;
-
lockdep_assert_held(&nvmet_config_sem);
port->enabled = false;
- ops = nvmet_transports[port->disc_addr.trtype];
- ops->remove_port(port);
- module_put(ops->owner);
+ port->ops->remove_port(port);
+ module_put(port->ops->owner);
+ port->ops = NULL;
}
static void nvmet_keep_alive_timer(struct work_struct *work)
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index 15fd84ab21f8..bc04e5db3a12 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -98,6 +98,7 @@ struct nvmet_port {
struct list_head referrals;
void *priv;
bool enabled;
+ const struct nvmet_fabrics_ops *ops;
};
static inline struct nvmet_port *to_nvmet_port(struct config_item *item)
--
2.14.1
next prev parent reply other threads:[~2018-04-12 8:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 8:06 [PATCH v1 0/3] nvmet-rdma automatic port re-activation Sagi Grimberg
2018-04-12 8:06 ` [PATCH v1 1/3] nvmet-rdma: automatic listening " Sagi Grimberg
2018-04-12 13:08 ` Israel Rukshin
2018-04-12 8:06 ` Sagi Grimberg [this message]
2018-04-12 8:06 ` [PATCH v1 3/3] nvmet: Add port transport state flag Sagi Grimberg
2018-04-13 17:14 ` Christoph Hellwig
2018-04-15 8:54 ` Sagi Grimberg
2018-04-17 15:28 ` Christoph Hellwig
2018-05-16 12:40 ` Max Gurtovoy
2018-04-12 8:06 ` [PATCH 4/3 v1 nvmetcli] nvmetcli: expose nvmet port status and state Sagi Grimberg
2018-04-12 11:25 ` Nitzan Carmi
2018-04-12 12:34 ` Sagi Grimberg
2018-04-13 17:00 ` [PATCH v1 0/3] nvmet-rdma automatic port re-activation Christoph Hellwig
2018-04-15 8:53 ` Sagi Grimberg
2018-04-17 15:43 ` Christoph Hellwig
2018-04-20 2:48 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412080656.1691-3-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).