From: keith.busch@intel.com (Keith Busch)
Subject: 'modprobe nvme_core multipath=N' crashes in face of multipath fabric
Date: Thu, 12 Apr 2018 16:28:37 -0600 [thread overview]
Message-ID: <20180412222837.GE6424@localhost.localdomain> (raw)
In-Reply-To: <4b142a06-ff6a-0e68-2043-0ed2886b8d50@grimberg.me>
On Thu, Apr 12, 2018@11:12:12AM +0300, Sagi Grimberg wrote:
> On 04/12/2018 12:46 AM, Mike Snitzer wrote:
> > This patch fixed the issue for me. Verified that modprobe nvme_core
> > multipath=N and multipath=Y works with the mptest case I shared in my
> > original report.
> >
> > If you do go with this patch, please feel free to add:
> >
> > Tested-by: Mike Snitzer <snitzer at redhat.com>
>
> This looks good to me too, you can add my
>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
I'm going to have to make one minor change here since this will still
break if you've a multi-path subsystem with multiple namespaces. I'll
just need to move the IDA up to the subsystem level instead of on the
subsystem heads, but otherwise much the same.
prev parent reply other threads:[~2018-04-12 22:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 20:49 'modprobe nvme_core multipath=N' crashes in face of multipath fabric Mike Snitzer
2018-04-11 13:45 ` Keith Busch
2018-04-11 14:17 ` Mike Snitzer
2018-04-11 17:58 ` Keith Busch
2018-04-11 21:46 ` Mike Snitzer
2018-04-12 8:12 ` Sagi Grimberg
2018-04-12 22:28 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412222837.GE6424@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox