From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path
Date: Wed, 18 Apr 2018 17:07:10 +0200 [thread overview]
Message-ID: <20180418150710.GB7862@lst.de> (raw)
In-Reply-To: <20180418144524.GL11513@localhost.localdomain>
On Wed, Apr 18, 2018@08:45:25AM -0600, Keith Busch wrote:
> Nothing against this patch. This just doesn't look correct even from
> before since nvme_find_path can set head->current_path right back to
> this namespace that we're trying to clear.
>
> Christoph, am I missing something here or does this need additional
> checks/synchronization?
Yes, we should probably call it after removing the namespace from
the ns_head list, instead of right before.
prev parent reply other threads:[~2018-04-18 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 7:32 [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path Jianchao Wang
2018-04-18 10:19 ` Christoph Hellwig
2018-04-18 14:45 ` Keith Busch
2018-04-18 15:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418150710.GB7862@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox