Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] nvme/multipath: Disable runtime writable enabling parameter
Date: Thu, 26 Apr 2018 15:49:55 -0600	[thread overview]
Message-ID: <20180426214956.3377-2-keith.busch@intel.com> (raw)
In-Reply-To: <20180426214956.3377-1-keith.busch@intel.com>

We can't allow the user to change multipath settings at runtime, as this
will create naming conflicts due to the different naming schemes used
for each mode.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/multipath.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 956e0b8e9c4d..3ded009e7631 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -15,7 +15,7 @@
 #include "nvme.h"
 
 static bool multipath = true;
-module_param(multipath, bool, 0644);
+module_param(multipath, bool, 0444);
 MODULE_PARM_DESC(multipath,
 	"turn on native support for multiple controllers per subsystem");
 
-- 
2.14.3

  reply	other threads:[~2018-04-26 21:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 21:49 [PATCH 0/2] nvme multipath naming fixes Keith Busch
2018-04-26 21:49 ` Keith Busch [this message]
2018-04-27  5:20   ` [PATCH 1/2] nvme/multipath: Disable runtime writable enabling parameter Christoph Hellwig
2018-04-27 15:48     ` Keith Busch
2018-10-30 18:17   ` Sagi Grimberg
2018-10-30 18:18     ` Sagi Grimberg
2018-10-30 18:24       ` Keith Busch
2018-10-31  5:28         ` Christoph Hellwig
2018-04-26 21:49 ` [PATCH 2/2] nvme/multipath: Fix multipath disabled naming collisions Keith Busch
2018-04-27  5:21   ` Christoph Hellwig
2018-10-29 15:37   ` Stephen  Bates
2018-10-29 15:42     ` Keith Busch
2018-10-29 15:48       ` Stephen  Bates
2018-10-29 15:55         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426214956.3377-2-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox