Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-cli: Add ioctl retry support for connect-all
Date: Fri, 27 Apr 2018 15:39:42 -0600	[thread overview]
Message-ID: <20180427213942.GC5073@localhost.localdomain> (raw)
In-Reply-To: <20180427172901.3479-1-jsmart2021@gmail.com>

On Fri, Apr 27, 2018@10:29:01AM -0700, James Smart wrote:
>  /* Generic passthrough */
> -int nvme_submit_passthru(int fd, int ioctl_cmd, struct nvme_passthru_cmd *cmd);
> +int nvme_submit_passthru(int fd, int ioctl_cmd, struct nvme_passthru_cmd *cmd,
> +		int maxretry);

Hi James,

Since the far majority of the callers don't care for retries, let's
leave this API alone and create a new one that takes the retries. The
old API can call the new one with the default value of NO_RETRIES, and
that should simplify this patch significantly.

Thanks,
Keith

  reply	other threads:[~2018-04-27 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 17:29 [PATCH] nvme-cli: Add ioctl retry support for connect-all James Smart
2018-04-27 21:39 ` Keith Busch [this message]
2018-04-30 16:45   ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427213942.GC5073@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox