From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH] nvme/pci: Use async_schedule for initial reset work
Date: Wed, 2 May 2018 09:29:53 -0600 [thread overview]
Message-ID: <20180502152953.GH5938@localhost.localdomain> (raw)
In-Reply-To: <alpine.LRH.2.02.1805011928470.17838@file01.intranet.prod.int.rdu2.redhat.com>
On Tue, May 01, 2018@07:33:10PM -0400, Mikulas Patocka wrote:
> On Mon, 30 Apr 2018, Keith Busch wrote:
>
> > On Sat, Apr 28, 2018@05:11:18PM +0800, Ming Lei wrote:
> > > Looks fine,
> > >
> > > Reviewed-by: Ming Lei <ming.lei at redhat.com>
> >
> > Thanks, Ming.
> >
> > Mikulas, would you be able to test this and confirm it works for you?
> > This appears successful in my testing, but want to hear from the source
> > if possible.
> >
> > Thanks,
> > Keith
>
> The patch is not correct - scan_work is still called from a workqueue and
> if it's too slow, the nvme device is not found when mounting root.
>
> You can add msleep(10000) at the beginning of nvme_scan_work to test for
> the race condition on your system.
>
> Here I submit the corrected patch - I added
> flush_work(&dev->ctrl.scan_work) to nvme_async_probe
Roger that. Will incorporate your adjustment and add your
Tested-by. Thanks for the confirmation.
next prev parent reply other threads:[~2018-05-02 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 21:17 [PATCH] nvme/pci: Use async_schedule for initial reset work Keith Busch
2018-04-28 9:11 ` Ming Lei
2018-04-30 19:45 ` Keith Busch
2018-05-01 23:33 ` Mikulas Patocka
2018-05-02 15:29 ` Keith Busch [this message]
2018-05-03 14:55 ` Mikulas Patocka
2018-05-03 20:15 ` Keith Busch
2018-05-03 20:45 ` Mikulas Patocka
2018-05-03 21:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502152953.GH5938@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox