From mboxrd@z Thu Jan  1 00:00:00 1970
From: keith.busch@linux.intel.com (Keith Busch)
Date: Fri, 4 May 2018 10:17:36 -0600
Subject: [PATCH 2/5] nvme: Add ANA base definitions
In-Reply-To: <20180504112845.38820-3-hare@suse.de>
References: <20180504112845.38820-1-hare@suse.de>
 <20180504112845.38820-3-hare@suse.de>
Message-ID: <20180504161736.GQ5938@localhost.localdomain>

On Fri, May 04, 2018@01:28:42PM +0200, Hannes Reinecke wrote:
> @@ -312,7 +317,8 @@ struct nvme_id_ns {
>  	__le16			nabspf;
>  	__le16			noiob;
>  	__u8			nvmcap[16];
> -	__u8			rsvd64[40];
> +	__u8			rsvd64[36];
> +	__le32			anagrpid;
>  	__u8			nguid[16];
>  	__u8			eui64[8];
>  	struct nvme_lbaf	lbaf[16];

Is this the right place for the new field? Your patch has the group ID
at byte 100. TP4004 has the ANA Group Identifier starting at byte 92,
followed by 8 reserved bytes, then the NGUID.