From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH v2] nvme: add quirk to force medium priority for SQ creation
Date: Tue, 8 May 2018 10:22:26 -0600 [thread overview]
Message-ID: <20180508162226.GA31027@localhost.localdomain> (raw)
In-Reply-To: <879357dd-937c-4496-84af-f804877562eb@kernel.dk>
On Tue, May 08, 2018@09:54:20AM -0600, Jens Axboe wrote:
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1097,6 +1097,14 @@ static int adapter_alloc_sq(struct nvme_dev *dev, u16 qid,
> int flags = NVME_QUEUE_PHYS_CONTIG;
>
> /*
> + * Some drives have a bug that auto-enables WRRU if MEDIUM isn't
> + * set. Since URGENT priority is zeroes, it makes all queues
> + * URGENT.
> + */
> + if (ctrl->quirks & NVME_QUIRK_MEDIUM_PRIO_SQ)
> + flags |= NVME_SQ_PRIO_MEDIUM;
'ctrl' is undeclared in this function; must be 'dev->ctrl.quirks'.
next prev parent reply other threads:[~2018-05-08 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 15:54 [PATCH v2] nvme: add quirk to force medium priority for SQ creation Jens Axboe
2018-05-08 16:22 ` Keith Busch [this message]
2018-05-08 16:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508162226.GA31027@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).