* [PATCH] nvmet: make the error message more generic
@ 2018-05-08 6:02 Chaitanya Kulkarni
2018-05-08 7:16 ` Johannes Thumshirn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2018-05-08 6:02 UTC (permalink / raw)
"nvmet_check_ctrl_status()" is called from admin-cmd.c along
with io-cmd.c, make the error message more generic.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---
drivers/nvme/target/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index e95424f172fd..4a9908bb7de0 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -710,13 +710,13 @@ u16 nvmet_ctrl_find_get(const char *subsysnqn, const char *hostnqn, u16 cntlid,
u16 nvmet_check_ctrl_status(struct nvmet_req *req, struct nvme_command *cmd)
{
if (unlikely(!(req->sq->ctrl->cc & NVME_CC_ENABLE))) {
- pr_err("got io cmd %d while CC.EN == 0 on qid = %d\n",
+ pr_err("got cmd %d while CC.EN == 0 on qid = %d\n",
cmd->common.opcode, req->sq->qid);
return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;
}
if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) {
- pr_err("got io cmd %d while CSTS.RDY == 0 on qid = %d\n",
+ pr_err("got cmd %d while CSTS.RDY == 0 on qid = %d\n",
cmd->common.opcode, req->sq->qid);
req->ns = NULL;
return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] nvmet: make the error message more generic
2018-05-08 6:02 [PATCH] nvmet: make the error message more generic Chaitanya Kulkarni
@ 2018-05-08 7:16 ` Johannes Thumshirn
2018-05-09 5:10 ` Christoph Hellwig
2018-05-25 9:10 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2018-05-08 7:16 UTC (permalink / raw)
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvmet: make the error message more generic
2018-05-08 6:02 [PATCH] nvmet: make the error message more generic Chaitanya Kulkarni
2018-05-08 7:16 ` Johannes Thumshirn
@ 2018-05-09 5:10 ` Christoph Hellwig
2018-05-25 9:10 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2018-05-09 5:10 UTC (permalink / raw)
On Tue, May 08, 2018@02:02:33AM -0400, Chaitanya Kulkarni wrote:
> "nvmet_check_ctrl_status()" is called from admin-cmd.c along
> with io-cmd.c, make the error message more generic.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvmet: make the error message more generic
2018-05-08 6:02 [PATCH] nvmet: make the error message more generic Chaitanya Kulkarni
2018-05-08 7:16 ` Johannes Thumshirn
2018-05-09 5:10 ` Christoph Hellwig
@ 2018-05-25 9:10 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2018-05-25 9:10 UTC (permalink / raw)
Thanks,
applied to nvme-4.18-2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-25 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-08 6:02 [PATCH] nvmet: make the error message more generic Chaitanya Kulkarni
2018-05-08 7:16 ` Johannes Thumshirn
2018-05-09 5:10 ` Christoph Hellwig
2018-05-25 9:10 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).