From: keith.busch@intel.com (Keith Busch)
Subject: Deprecating NVME_IOCTL_SUBSYS_RESET
Date: Thu, 10 May 2018 10:13:08 -0600 [thread overview]
Message-ID: <20180510161308.GA4477@localhost.localdomain> (raw)
In-Reply-To: <866e6766-3a3f-8d14-8475-481e839502ad@gmail.com>
On Thu, May 10, 2018@10:06:42AM -0500, Alex G. wrote:
> There are ways to harden the IOCTL by quiescing all IO before issuing the
> actual reset. Such safeguards are implemented everywhere else in the driver.
> Is NVME_IOCTL_SUBSYS_RESET used in the real-world? I think it's too big of
> an attack surface, and we're better off with -EOPNOTSUPP.
Quiescing here is not really a solution since an NVMe Subsystem Reset
resets all the controllers in that subsystem, some of which may be
connected to different hosts: we can't quiesce those other hosts from
the driver level on the host issuing the reset.
I'm not sure we want to get rid of this feature either since this is
sometimes the only option for completing a firmware upgrade.
That said, I have heard enough cases where this reset method is not
successful, so there's some work to do here. Most failures seem to be
around the handling of the rapid link down-up sequence, and success
seems very dependent on the platform and the device used.
next prev parent reply other threads:[~2018-05-10 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 15:06 Deprecating NVME_IOCTL_SUBSYS_RESET Alex G.
2018-05-10 16:13 ` Keith Busch [this message]
2018-05-10 16:18 ` Alex_Gagniuc
2018-05-10 16:52 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510161308.GA4477@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).