From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V3] nvmet: add simple file backed ns support
Date: Thu, 10 May 2018 19:40:45 +0200 [thread overview]
Message-ID: <20180510174045.GA29461@lst.de> (raw)
In-Reply-To: <CAK0tqimM8W5DHfg=UbvHdTKCNsM3cqqqDZYMnLkVK=EC06Qv-A@mail.gmail.com>
On Wed, May 09, 2018@08:59:39PM -0700, chaitany kulkarni wrote:
> Also for bvec_alloc() we have to maintain the mempool_t, can we not
> add more members
> when we can get away with kmalloc_array()?
>
> Do you see any performance advantage/difference when using
> bvec_alloc() vs kmalloc_array()?
The mempool is required to make guranteed forward progress under
memory reclaim. For nvmet this only really matters for nvme-loop,
but I suspect we should still fix it.
Just use a global mempool - bvec_alloc isn't even exported and I'd
like to keep it this way. One easy way to piggy back on the block
layer would be to always allocate bios, even for the file backed
code and then just use the bvecs.
prev parent reply other threads:[~2018-05-10 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 5:38 [PATCH V3] nvmet: add simple file backed ns support Chaitanya Kulkarni
2018-05-09 5:53 ` Christoph Hellwig
2018-05-10 3:51 ` chaitany kulkarni
2018-05-09 14:53 ` Sagi Grimberg
2018-05-10 3:59 ` chaitany kulkarni
2018-05-10 17:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510174045.GA29461@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).