From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH v3] nvme: add quirk to force medium priority for SQ creation
Date: Fri, 11 May 2018 11:02:53 -0600 [thread overview]
Message-ID: <20180511170252.GA7344@localhost.localdomain> (raw)
In-Reply-To: <20180508163539.GB31027@localhost.localdomain>
On Tue, May 08, 2018@10:35:39AM -0600, Keith Busch wrote:
> On Tue, May 08, 2018@10:25:15AM -0600, Jens Axboe wrote:
> > Some P3100 drives have a bug where they think WRRU (weighted round
> > robin) is always enabled, even though the host doesn't set it. Since
> > they think it's enabled, they also look at the submission queue
> > creation priority. We used to set that to MEDIUM by default,
> > but that was removed in commit 81c1cd98351b. This causes various
> > issues on that drive. Add a quick to still set MEDIUM priority
> > for that controller.
> >
> > Fixes: 81c1cd98351b ("nvme/pci: Don't set reserved SQ create flags")
> > Cc: stable at vger.kernel.org
> > Signed-off-by: Jens Axboe <axboe at kernel.dk>
>
> Thanks, applied to nvme-4.18.
Actually, any concern if I apply for the next 4.17-rc instead? I know
this breakage isn't all that recent, but there seems to be heightened
visibility on getting this work-around to users.
next prev parent reply other threads:[~2018-05-11 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 16:25 [PATCH v3] nvme: add quirk to force medium priority for SQ creation Jens Axboe
2018-05-08 16:35 ` Keith Busch
2018-05-11 17:02 ` Keith Busch [this message]
2018-05-11 21:05 ` Jens Axboe
[not found] ` <4feb7a21-14b1-be61-a88e-8c7841fae96c@huawei.com>
2018-05-15 15:23 ` Question about stream number Jens Axboe
2018-05-09 4:40 ` [PATCH v3] nvme: add quirk to force medium priority for SQ creation Christoph Hellwig
2018-05-09 14:05 ` Keith Busch
2018-05-09 14:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511170252.GA7344@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox