From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH] nvme: remove cq check after submission
Date: Thu, 17 May 2018 09:06:54 -0600 [thread overview]
Message-ID: <20180517150654.GE22063@localhost.localdomain> (raw)
In-Reply-To: <a2ac17fd-b836-fd3a-3c26-5ecd1acb567d@kernel.dk>
On Thu, May 17, 2018@08:16:17AM -0600, Jens Axboe wrote:
> On 5/17/18 12:50 AM, Christoph Hellwig wrote:
> > On Wed, May 16, 2018@03:20:10PM -0600, Keith Busch wrote:
> >> On Wed, May 16, 2018@01:58:08PM -0600, Jens Axboe wrote:
> >>> We always check the completion queue after submitting, but in my testing
> >>> this isn't a win even on DRAM/xpoint devices. In some cases it's
> >>> actually worse. Kill it.
> >>
> >> Right, this was on my todo list. Agreed it's not helping anything.
> >> Applied to nvme-4.18.
> >
> > While I agree in general didn't we have a case where this caused a
> > regression last time it came up? Not that I'd complain if it goes
> > away..
>
> Not that I'm aware of. I've been running with this patch for quite
> a while, while doing some work on polling.
Yah, I mentioned a few months back there appeared to be a problem with removing
this, but I was mistaken. I just didn't get back around to doing this.
prev parent reply other threads:[~2018-05-17 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 19:58 [PATCH] nvme: remove cq check after submission Jens Axboe
2018-05-16 21:20 ` Keith Busch
2018-05-17 6:50 ` Christoph Hellwig
2018-05-17 14:16 ` Jens Axboe
2018-05-17 15:06 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517150654.GE22063@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).