From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 1/3] nvme: remove ->cq_vector == -1 check in nvme_queue_rq()
Date: Thu, 17 May 2018 09:44:31 -0600 [thread overview]
Message-ID: <20180517154431.GC23555@localhost.localdomain> (raw)
In-Reply-To: <2d5e6a8b-b7fb-a0fa-614f-5888fdf0e8be@kernel.dk>
On Thu, May 17, 2018@09:36:58AM -0600, Jens Axboe wrote:
> I'd suggest we just move it to the top and get it out of the way instead,
> and ensure that the ->cq_vector to -1 includes an mb(). Then we can just
> make it:
>
> if (unlikely(nvmeq->cq_vector < 0))
> return BLK_STS_IOERR;
Yes, I like that!
next prev parent reply other threads:[~2018-05-17 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:02 [PATCHSET 0/3] Split queue lock into submission/completion locks Jens Axboe
2018-05-17 15:02 ` [PATCH 1/3] nvme: remove ->cq_vector == -1 check in nvme_queue_rq() Jens Axboe
2018-05-17 15:30 ` Christoph Hellwig
2018-05-17 15:32 ` Keith Busch
2018-05-17 15:36 ` Jens Axboe
2018-05-17 15:42 ` Jens Axboe
2018-05-17 15:52 ` Keith Busch
2018-05-17 15:52 ` Jens Axboe
2018-05-17 16:00 ` Christoph Hellwig
2018-05-17 15:44 ` Keith Busch [this message]
2018-05-17 15:02 ` [PATCH 2/3] nvme: split the nvme queue lock into submission and completion locks Jens Axboe
2018-05-17 15:33 ` Christoph Hellwig
2018-05-17 15:33 ` Jens Axboe
2018-05-17 15:02 ` [PATCH 3/3] nvme: drop IRQ disabling on submission queue lock Jens Axboe
2018-05-17 15:33 ` Christoph Hellwig
2018-05-17 15:22 ` [PATCHSET 0/3] Split queue lock into submission/completion locks Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517154431.GC23555@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).