From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@linux.intel.com (Keith Busch) Date: Thu, 17 May 2018 09:52:18 -0600 Subject: [PATCH 1/3] nvme: remove ->cq_vector == -1 check in nvme_queue_rq() In-Reply-To: <0e84a488-30cb-ec5e-95a6-65f0a9722a50@kernel.dk> References: <1526569337-3489-1-git-send-email-axboe@kernel.dk> <1526569337-3489-2-git-send-email-axboe@kernel.dk> <20180517153204.GA23555@localhost.localdomain> <2d5e6a8b-b7fb-a0fa-614f-5888fdf0e8be@kernel.dk> <0e84a488-30cb-ec5e-95a6-65f0a9722a50@kernel.dk> Message-ID: <20180517155218.GD23555@localhost.localdomain> On Thu, May 17, 2018@09:42:58AM -0600, Jens Axboe wrote: > How about this: > > http://git.kernel.dk/cgit/linux-block/commit/?h=nvme-4.18&id=9913686cb779a046924441cdcac275aa24147122 Not only better, this also fixes a memory leak: we never called the dma_unmap_sg() on this error out case! Let's consider this patch separately.