linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvmet-loop: use nr_phys_segments when map rq to sgl
Date: Fri, 18 May 2018 02:09:42 -0700	[thread overview]
Message-ID: <20180518090942.GB31336@infradead.org> (raw)
In-Reply-To: <20180511063815.14911-1-chaitanya.kulkarni@wdc.com>

On Fri, May 11, 2018@02:38:15AM -0400, Chaitanya Kulkarni wrote:
> This patch replaces blk_rq_payload_bytes() with
> blk_rq_nr_phys_segments(). For the payloadless requests like
> write-zeroes it will trigger BUD_ON() at
> sg_alloc_table_chained() since blk_rq_nr_phys_segments()
> will evaluate to 0 due to nature of the request.

Sorry for the noise, actually looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>

  parent reply	other threads:[~2018-05-18  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  6:38 [PATCH] nvmet-loop: use nr_phys_segments when map rq to sgl Chaitanya Kulkarni
2018-05-14  8:32 ` Christoph Hellwig
2018-05-14 22:17   ` chaitany kulkarni
2018-05-18  9:09     ` Christoph Hellwig
2018-05-18  9:09 ` Christoph Hellwig [this message]
2018-05-25  9:10 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518090942.GB31336@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).