From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH V6 11/11] nvme: pci: support nested EH
Date: Fri, 18 May 2018 10:28:04 -0600 [thread overview]
Message-ID: <20180518162804.GA27795@localhost.localdomain> (raw)
In-Reply-To: <20180517142345.t6bnyfne7ndgrxkg@linux-x5ow.site>
On Thu, May 17, 2018@04:23:45PM +0200, Johannes Thumshirn wrote:
> > Agreed. Alternatively possibly call the driver's reset_preparei/done
> > callbacks.
>
> Exactly, but as long as we can issue the reset via sysfs the test-case
> is still valid.
I disagree the test case is valid. The test writes '0' to the
pci-sysfs 'enable', but the driver also disables the pci device as part
of resetting, which is a perfectly reasonable thing for a driver to do.
If the timing of the test's loop happens to write '0' right after the
driver disabled the device that it owns, a 'write error' on that sysfs
write occurs, and blktests then incorrectly claims the test failed.
next prev parent reply other threads:[~2018-05-18 16:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 4:03 [PATCH V6 00/11] nvme: pci: fix & improve timeout handling Ming Lei
2018-05-16 4:03 ` [PATCH V6 01/11] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout() Ming Lei
2018-05-16 4:03 ` [PATCH V6 02/11] nvme: pci: cover timeout for admin commands running in EH Ming Lei
2018-05-24 15:39 ` Keith Busch
2018-05-16 4:03 ` [PATCH V6 03/11] nvme: pci: unquiesce admin queue after controller is shutdown Ming Lei
2018-05-16 4:03 ` [PATCH V6 04/11] nvme: pci: set nvmeq->cq_vector after alloc cq/sq Ming Lei
2018-05-16 4:03 ` [PATCH V6 05/11] nvme: pci: only wait freezing if queue is frozen Ming Lei
2018-05-16 4:03 ` [PATCH V6 06/11] nvme: pci: freeze queue in nvme_dev_disable() in case of error recovery Ming Lei
2018-05-16 4:03 ` [PATCH V6 07/11] nvme: pci: prepare for supporting error recovery from resetting context Ming Lei
2018-05-16 4:03 ` [PATCH V6 08/11] nvme: pci: move error handling out of nvme_reset_dev() Ming Lei
2018-05-16 4:03 ` [PATCH V6 09/11] nvme: pci: don't unfreeze queue until controller state updating succeeds Ming Lei
2018-05-16 4:03 ` [PATCH V6 10/11] nvme: core: introduce nvme_force_change_ctrl_state() Ming Lei
2018-05-16 4:03 ` [PATCH V6 11/11] nvme: pci: support nested EH Ming Lei
2018-05-16 14:12 ` Keith Busch
2018-05-16 23:10 ` Ming Lei
2018-05-17 2:20 ` Keith Busch
2018-05-17 8:41 ` Christoph Hellwig
2018-05-17 14:20 ` Keith Busch
2018-05-17 14:23 ` Johannes Thumshirn
2018-05-18 16:28 ` Keith Busch [this message]
2018-05-22 7:35 ` Johannes Thumshirn
2018-05-18 0:20 ` Ming Lei
2018-05-18 1:01 ` Ming Lei
2018-05-18 13:57 ` Keith Busch
2018-05-18 16:58 ` Jens Axboe
2018-05-18 22:26 ` Ming Lei
2018-05-18 23:45 ` Keith Busch
2018-05-18 23:51 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518162804.GA27795@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).