From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@linux.intel.com (Keith Busch) Date: Mon, 21 May 2018 09:44:33 -0600 Subject: [PATCH 3/6] nvme: Move all IO out of controller reset In-Reply-To: <20180521153425.GC19099@ming.t460p> References: <20180518163823.27820-1-keith.busch@intel.com> <20180518163823.27820-3-keith.busch@intel.com> <20180518230357.GC18334@ming.t460p> <20180521142219.GC5528@localhost.localdomain> <20180521145850.GA19099@ming.t460p> <20180521150331.GI5528@localhost.localdomain> <20180521153425.GC19099@ming.t460p> Message-ID: <20180521154433.GJ5528@localhost.localdomain> On Mon, May 21, 2018@11:34:27PM +0800, Ming Lei wrote: > nvme_dev_disable() quiesces queues first before killing queues. > > If queues are quiesced during or before nvme_wait_freeze() is run > from the 2nd part of reset, the 2nd part can't move on, and IO hang > is caused. Finally no reset can be scheduled at all. But this patch moves nvme_wait_freeze outside the reset path, so I'm afraid I'm unable to follow how you've concluded the wait freeze is somehow part of the reset.