From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@linux.intel.com (Keith Busch) Date: Mon, 21 May 2018 10:25:17 -0600 Subject: [PATCH 1/6] nvme: Sync request queues on reset In-Reply-To: <20180521160830.GA19858@ming.t460p> References: <20180518163823.27820-1-keith.busch@intel.com> <20180518223210.GB18334@ming.t460p> <20180518234408.GA31749@localhost.localdomain> <20180519000141.GB19799@ming.t460p> <20180521140413.GA5528@localhost.localdomain> <20180521152536.GB19099@ming.t460p> <20180521155909.GK5528@localhost.localdomain> <20180521160830.GA19858@ming.t460p> Message-ID: <20180521162517.GN5528@localhost.localdomain> On Tue, May 22, 2018@12:08:37AM +0800, Ming Lei wrote: > Please take a look at blk_mq_complete_request(). Even with Bart's > change, the request still won't be completed by driver. The request can > only be completed by either driver or blk-mq, not both. So you're saying blk-mq can't complete a request the driver returned to blk-mq to complete. And that's the nvme driver's problem to fix?