[PATCHv3 5/9] nvme-pci: End IO requests in CONNECTING state

[hch@lst.de (Christoph Hellwig)]

On Thu, May 24, 2018@02:34:56PM -0600, Keith Busch wrote:
> IO is always quiesced in the CONNECTING state, so any any timeout for an
> IO command had already been completed.
> 
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
>  drivers/nvme/host/pci.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 6be88f662e7d..54e22b964385 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1227,6 +1227,14 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
>  	 */
>  	switch (dev->ctrl.state) {
>  	case NVME_CTRL_CONNECTING:
> +		/*
> +		 * IO is never dispatched from the connecting state. If an IO
> +		 * queue timed out here, the block layer missed the completion
> +		 * the driver already requested, so return handled.
> +		 */
> +		if (nvmeq->qid)
> +			return BLK_EH_HANDLED;

How can we hit this case?  This just looks a lot like papering
over the real issue..