From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCHv3 1/9] nvme: Sync request queues on reset
Date: Fri, 25 May 2018 08:45:37 -0600 [thread overview]
Message-ID: <20180525144536.GQ11037@localhost.localdomain> (raw)
In-Reply-To: <20180525143253.GA26539@lst.de>
On Fri, May 25, 2018@04:32:53PM +0200, Christoph Hellwig wrote:
> Ok, so we are talking about simultaneous nvme_dev_disable calls, which
> makes more sense.
>
> That being said I really like the idea that Jianchao floated about
> always returning BLK_EH_RESET_TIMER and just letting the reset work
> do the work. I hope it actually works and doesn't have hidden
> pitfalls..
There are some pitfalls there. The reset_work won't queue if we're in the
DELETING state, for example, and we do still need something to disable
the controller if an admin command issued within reset_work times out. We
do the nvme_dev_disable inline with the timeout for those reasons.
next prev parent reply other threads:[~2018-05-25 14:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 20:34 [PATCHv3 0/9] nvme timeout fixes, v3 Keith Busch
2018-05-24 20:34 ` [PATCHv3 1/9] nvme: Sync request queues on reset Keith Busch
2018-05-25 12:42 ` Christoph Hellwig
2018-05-25 14:22 ` Keith Busch
2018-05-25 14:32 ` Christoph Hellwig
2018-05-25 14:45 ` Keith Busch [this message]
2018-05-25 15:56 ` James Smart
2018-05-25 16:24 ` Keith Busch
2018-05-25 18:04 ` James Smart
2018-05-25 18:30 ` Keith Busch
2018-05-30 23:25 ` Sagi Grimberg
2018-06-05 16:25 ` Keith Busch
2018-05-30 23:24 ` Sagi Grimberg
2018-05-24 20:34 ` [PATCHv3 2/9] nvme-pci: Fix queue freeze criteria " Keith Busch
2018-05-25 12:43 ` Christoph Hellwig
2018-05-30 23:36 ` Sagi Grimberg
2018-05-24 20:34 ` [PATCHv3 3/9] nvme: Move all IO out of controller reset Keith Busch
2018-05-25 13:00 ` Christoph Hellwig
2018-05-25 14:41 ` Keith Busch
2018-05-24 20:34 ` [PATCHv3 4/9] nvme-pci: Rate limit the nvme timeout warnings Keith Busch
2018-05-25 13:01 ` Christoph Hellwig
2018-05-30 6:06 ` Christoph Hellwig
2018-05-24 20:34 ` [PATCHv3 5/9] nvme-pci: End IO requests in CONNECTING state Keith Busch
2018-05-24 20:47 ` Christoph Hellwig
2018-05-24 21:03 ` Keith Busch
2018-05-25 12:31 ` Christoph Hellwig
2018-05-24 20:34 ` [PATCHv3 6/9] nvme-pci: Unquiesce dead controller queues Keith Busch
2018-05-25 13:03 ` Christoph Hellwig
2018-05-24 20:34 ` [PATCHv3 7/9] nvme-pci: Attempt reset retry for IO failures Keith Busch
2018-05-25 13:04 ` Christoph Hellwig
2018-05-25 14:25 ` Keith Busch
2018-05-30 23:40 ` Sagi Grimberg
2018-06-04 22:46 ` Keith Busch
2018-05-24 20:34 ` [PATCHv3 8/9] nvme-pci: Queue creation error handling Keith Busch
2018-05-25 12:35 ` Christoph Hellwig
2018-06-05 16:28 ` Keith Busch
2018-05-30 23:37 ` Sagi Grimberg
2018-05-24 20:35 ` [PATCHv3 9/9] nvme-pci: Don't wait for HMB completion on shutdown Keith Busch
2018-05-24 20:45 ` Christoph Hellwig
2018-05-24 21:15 ` Keith Busch
2018-05-25 3:10 ` jianchao.wang
2018-05-25 15:09 ` Keith Busch
2018-05-25 12:36 ` Christoph Hellwig
2018-07-13 0:48 ` [PATCHv3 0/9] nvme timeout fixes, v3 Ming Lei
2018-07-13 20:54 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525144536.GQ11037@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).