linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: snitzer@redhat.com (Mike Snitzer)
Subject: [PATCH 0/3] Provide more fine grained control over multipathing
Date: Fri, 25 May 2018 10:50:56 -0400	[thread overview]
Message-ID: <20180525145056.GD9591@redhat.com> (raw)
In-Reply-To: <20180525141211.GA25971@lst.de>

On Fri, May 25 2018 at 10:12am -0400,
Christoph Hellwig <hch@lst.de> wrote:

> On Fri, May 25, 2018@09:58:13AM -0400, Mike Snitzer wrote:
> > We all basically knew this would be your position.  But at this year's
> > LSF we pretty quickly reached consensus that we do in fact need this.
> > Except for yourself, Sagi and afaik Martin George: all on the cc were in
> > attendance and agreed.
> 
> And I very mich disagree, and you'd bette come up with a good reason
> to overide me as the author and maintainer of this code.

I hope you don't truly think this is me vs you.

Some of the reasons are:
1) we need flexibility during the transition to native NVMe multipath
2) we need to support existing customers' dm-multipath storage networks
3) asking users to use an entirely new infrastructure that conflicts
   with their dm-multipath expertise and established norms is a hard
   sell.  Especially for environments that have a mix of traditional
   multipath (FC, iSCSI, whatever) and NVMe over fabrics.
4) Layered products (both vendor provided and user developed) have been
   trained to fully support and monitor dm-multipath; they have no
   understanding of native NVMe multipath

> > And since then we've exchanged mails to refine and test Johannes'
> > implementation.
> 
> Since when was acting behind the scenes a good argument for anything?

I mentioned our continued private collaboration to establish that this
wasn't a momentary weakness by anyone at LSF.  It has had a lot of soak
time in our heads.

We did it privately because we needed a concrete proposal that works for
our needs.  Rather than getting shot down over some shortcoming in an
RFC-style submission.
 
> > Hopefully this clarifies things, thanks.
> 
> It doesn't.
> 
> The whole point we have native multipath in nvme is because dm-multipath
> is the wrong architecture (and has been, long predating you, nothing
> personal).  And I don't want to be stuck additional decades with this
> in nvme.  We allowed a global opt-in to ease the three people in the
> world with existing setups to keep using that, but I also said I
> won't go any step further.  And I stand to that.

Thing is you really don't get to dictate that to the industry.  Sorry.

Reality is this ability to switch "native" vs "other" gives us the
options I've been talking about absolutely needing since the start of
this NVMe multipathing debate.

Your fighting against it for so long has prevented progress on NVMe
multipath in general.  Taking this change will increase native NVMe
multipath deployment.  Otherwise we're just going to have to disable
native multipath entirely for the time being.  That does users a
disservice because I completely agree that there _will_ be setups where
native NVMe multipath really does offer a huge win.  But those setups
could easily be deployed on the same hosts as another variant of NVMe
that really does want the use of the legacy DM multipath stack (possibly
even just for reason 4 above).

Mike

  reply	other threads:[~2018-05-25 14:50 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 12:53 [PATCH 0/3] Provide more fine grained control over multipathing Johannes Thumshirn
2018-05-25 12:53 ` [PATCH 1/3] nvme: provide a way to disable nvme mpath per subsystem Johannes Thumshirn
2018-05-25 13:47   ` Mike Snitzer
2018-05-31  8:17   ` Sagi Grimberg
2018-05-25 12:53 ` [PATCH 2/3] nvme multipath: added SUBSYS_ATTR_RW Johannes Thumshirn
2018-05-25 12:53 ` [PATCH 3/3] nvme multipath: add dev_attr_mpath_personality Johannes Thumshirn
2018-05-25 13:05 ` [PATCH 0/3] Provide more fine grained control over multipathing Christoph Hellwig
2018-05-25 13:58   ` Mike Snitzer
2018-05-25 14:12     ` Christoph Hellwig
2018-05-25 14:50       ` Mike Snitzer [this message]
2018-05-29  1:19         ` Martin K. Petersen
2018-05-29  3:02           ` Mike Snitzer
2018-05-29  7:18             ` Hannes Reinecke
2018-05-29  7:22             ` Johannes Thumshirn
2018-05-29  8:09               ` Christoph Hellwig
2018-05-29  9:54                 ` Mike Snitzer
2018-05-29 23:27                 ` Mike Snitzer
2018-05-30 19:05                   ` Jens Axboe
2018-05-30 19:59                     ` Mike Snitzer
2018-06-04  6:19                     ` Hannes Reinecke
2018-06-04  7:18                       ` Johannes Thumshirn
2018-06-04 12:59                         ` Christoph Hellwig
2018-06-04 13:27                           ` Mike Snitzer
2018-05-31  2:42               ` Ming Lei
2018-05-30 21:20     ` Sagi Grimberg
2018-05-30 22:02       ` Mike Snitzer
2018-05-31  8:37         ` Sagi Grimberg
2018-05-31 12:37           ` Mike Snitzer
2018-05-31 16:34             ` Christoph Hellwig
2018-06-01  4:11               ` Mike Snitzer
2018-05-31 16:36           ` Christoph Hellwig
2018-05-31 16:33         ` Christoph Hellwig
2018-05-31 18:17           ` Mike Snitzer
2018-06-01  2:40             ` Martin K. Petersen
2018-06-01  4:24               ` Mike Snitzer
2018-06-01 14:09                 ` Martin K. Petersen
2018-06-01 15:21                   ` Mike Snitzer
2018-06-03 11:00                 ` Sagi Grimberg
2018-06-03 16:06                   ` Mike Snitzer
2018-06-04 11:46                     ` Sagi Grimberg
2018-06-04 12:48                       ` Johannes Thumshirn
2018-05-30 22:44       ` Mike Snitzer
2018-05-31  8:51         ` Sagi Grimberg
2018-05-31 12:41           ` Mike Snitzer
2018-06-04 21:58       ` Roland Dreier
2018-06-05  4:42         ` Christoph Hellwig
2018-06-05 22:57           ` Roland Dreier
2018-06-06  9:51             ` Christoph Hellwig
2018-06-06  9:32           ` Sagi Grimberg
2018-06-06  9:50             ` Christoph Hellwig
2018-05-25 14:22   ` Johannes Thumshirn
2018-05-25 14:30     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525145056.GD9591@redhat.com \
    --to=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).