From: hch@lst.de (hch@lst.de)
Subject: Question on inline support
Date: Tue, 29 May 2018 19:44:42 +0200 [thread overview]
Message-ID: <20180529174442.GA1637@lst.de> (raw)
In-Reply-To: <5276f947-0ccf-5d0e-53bc-724f65c1c837@opengridcomputing.com>
On Tue, May 29, 2018@12:33:56PM -0500, Steve Wise wrote:
> Hey guys,
>
> While testing the nvme rdma target with inline_data_size=0 for my patch
> series [1], I found that the nvme host side rejected the queue
> connections with this error:
>
> "nvme nvme0: Mandatory keyed sgls are not support"
>
> Due to this code in nvme/host/rdma.c:
>
> ?????? /* sanity check keyed sgls */
> ?????? if (!(ctrl->ctrl.sgls & (1 << 20))) {
> ?????????????? dev_err(ctrl->ctrl.device, "Mandatory keyed sgls are not
> support\n");
> ?????????????? ret = -EINVAL;
> ?????????????? goto out_remove_admin_queue;
> ?????? }
Keyed SGLs are bit 2, so the above should check for bit 2 as well.
We should still check for bit 20 if inline data is supported, though.
next prev parent reply other threads:[~2018-05-29 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 17:33 Question on inline support Steve Wise
2018-05-29 17:44 ` hch [this message]
2018-05-29 17:48 ` Steve Wise
2018-05-29 18:33 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529174442.GA1637@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).