[PATCH] nvme: report subsystem-reset not supported by controller.

[PATCH] nvme: report subsystem-reset not supported by controller.

[David Milburn]

Add a little more description for "nvme subsystem-reset"
failures, currently driver reports "Inappropriate ioctl
for device".

$ nvme subsystem-reset /dev/nvme0
Subsystem-reset: Inappropriate ioctl for device

With this change report not permitted on controller's that
do not support NVM Subsystem Reset.

$ nvme subsystem-reset /dev/nvme0
Subsystem-reset: Operation not permitted

<dmesg>
[   88.261923] nvme nvme0: NVM Subsystem Reset not supported.
---
 drivers/nvme/host/nvme.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 17d2f7c..319fc39 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -343,8 +343,10 @@ static inline bool nvme_ctrl_ready(struct nvme_ctrl *ctrl)
 
 static inline int nvme_reset_subsystem(struct nvme_ctrl *ctrl)
 {
-	if (!ctrl->subsystem)
-		return -ENOTTY;
+	if (!ctrl->subsystem) {
+		dev_err(ctrl->device, "NVM Subsystem Reset not supported.\n");
+		return -EPERM;
+	}
 	return ctrl->ops->reg_write32(ctrl, NVME_REG_NSSR, 0x4E564D65);
 }
 
-- 
1.8.3.1

[PATCH] nvme: report subsystem-reset not supported by controller.

[Christoph Hellwig]

On Tue, May 29, 2018@03:42:34PM -0500, David Milburn wrote:
> Add a little more description for "nvme subsystem-reset"
> failures, currently driver reports "Inappropriate ioctl
> for device".

A warning sounds nice, but why can't we add it in nvme-cli?

[PATCH] nvme: report subsystem-reset not supported by controller.

[David Milburn]

Hi,

On 05/31/2018 11:22 AM, Christoph Hellwig wrote:
> On Tue, May 29, 2018@03:42:34PM -0500, David Milburn wrote:
>> Add a little more description for "nvme subsystem-reset"
>> failures, currently driver reports "Inappropriate ioctl
>> for device".
> 
> A warning sounds nice, but why can't we add it in nvme-cli?

Ok, will do.

Thanks,
David

> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>