From: hch@lst.de (hch@lst.de)
Subject: [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl support
Date: Thu, 31 May 2018 19:00:09 +0200 [thread overview]
Message-ID: <20180531170009.GA31715@lst.de> (raw)
In-Reply-To: <14063C7AD467DE4B82DEDB5C278E8663B38EE822@FMSMSX108.amr.corp.intel.com>
On Tue, May 29, 2018@08:23:09PM +0000, Ruhl, Michael J wrote:
> I can see that the 2 and 20 are defined for specific things. Since they are
> used in several places (in the next 2 patches), is there any chance these
> could be defined bits?
So far our rule of thumb was to use defines where the NVMe spec
defines symbolic names, and use plain bit numbers where the spec
does the same. The SGLS field falls into the latter category.
If we end up with a lot of users a little helper function might be
nice, but I don't think we aren't there yet.
next prev parent reply other threads:[~2018-05-31 17:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 18:26 [PATCH v3 0/3] NVMF/RDMA 16K Inline Support Steve Wise
2018-05-29 18:25 ` [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl support Steve Wise
2018-05-29 20:23 ` Ruhl, Michael J
2018-05-30 14:39 ` Steve Wise
2018-05-30 15:11 ` Steve Wise
2018-05-30 21:37 ` Sagi Grimberg
2018-05-31 17:02 ` hch
2018-05-31 17:17 ` Steve Wise
2018-05-31 17:25 ` hch
2018-06-01 13:08 ` Steve Wise
2018-06-03 11:57 ` Sagi Grimberg
2018-06-03 18:27 ` Steve Wise
2018-06-04 12:01 ` Sagi Grimberg
2018-06-04 12:11 ` Christoph Hellwig
2018-06-04 12:17 ` Steve Wise
2018-06-04 13:52 ` Max Gurtovoy
2018-06-04 14:21 ` Steve Wise
2018-06-04 14:29 ` Max Gurtovoy
2018-06-04 14:31 ` Steve Wise
2018-06-04 14:37 ` Max Gurtovoy
2018-06-04 14:45 ` Steve Wise
2018-05-31 17:00 ` hch [this message]
2018-05-29 18:25 ` [PATCH v3 2/3] nvme-rdma: support up to 4 segments of inline data Steve Wise
2018-05-30 21:42 ` Sagi Grimberg
2018-05-30 21:46 ` Steve Wise
2018-05-29 18:25 ` [PATCH v3 3/3] nvmet-rdma: support 16K " Steve Wise
2018-05-30 15:49 ` Christopher Lameter
2018-05-30 16:46 ` Steve Wise
2018-05-30 17:02 ` Christopher Lameter
2018-05-30 21:45 ` Sagi Grimberg
2018-05-30 21:52 ` Steve Wise
2018-05-30 22:13 ` Sagi Grimberg
2018-05-30 22:26 ` Steve Wise
2018-06-03 8:39 ` Max Gurtovoy
2018-06-03 18:25 ` Steve Wise
2018-06-04 13:58 ` Max Gurtovoy
2018-06-04 14:18 ` Steve Wise
2018-06-05 8:52 ` Max Gurtovoy
2018-06-05 14:28 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531170009.GA31715@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).