linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH 9/9] nvmet: make ANATT configurable
Date: Mon, 4 Jun 2018 12:21:02 +0200	[thread overview]
Message-ID: <20180604122102.4bfcd154@pentland.suse.de> (raw)
In-Reply-To: <20180601071128.7630-10-hch@lst.de>

On Fri,  1 Jun 2018 09:11:28 +0200
Christoph Hellwig <hch@lst.de> wrote:

> From: Hannes Reinecke <hare at suse.de>
> 
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>  drivers/nvme/target/admin-cmd.c |  2 +-
>  drivers/nvme/target/configfs.c  | 29 +++++++++++++++++++++++++++++
>  drivers/nvme/target/core.c      |  1 +
>  drivers/nvme/target/nvmet.h     |  2 ++
>  4 files changed, 33 insertions(+), 1 deletion(-)
> 

_Actually_ I would like to retract this patch.

I've been working on implementing ANA TT on the target, and found this
particular implementation unworkable.

The problem is that with the current implementation the ANA state is
pretty much tied to the _port_, which might be shared across several
subsystems. Consequently any state change might affect namespaces
on several subsystems, too.

But if the anatt value is tied to the subsystem we'd need to have
different timers/workqueue items per port and subsystem/namespace, which
doesn't really scale. Plus we're not giving anything away by making the
anatt per port, not per subsys.

Please?

Cheers,

Hannes

  reply	other threads:[~2018-06-04 10:21 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01  7:11 draft ANA support v2 Christoph Hellwig
2018-06-01  7:11 ` [PATCH 1/9] nvme: don't hold nvmf_transports_rwsem for more than transport lookups Christoph Hellwig
2018-06-03 12:26   ` Sagi Grimberg
2018-06-04  6:30   ` Hannes Reinecke
2018-06-01  7:11 ` [PATCH 2/9] nvme.h: add ANA definitions Christoph Hellwig
2018-06-03 12:27   ` Sagi Grimberg
2018-06-04  6:30   ` Hannes Reinecke
2018-06-04 11:58   ` Johannes Thumshirn
2018-06-01  7:11 ` [PATCH 3/9] nvme: add support for the log specific field Christoph Hellwig
2018-06-03 12:27   ` Sagi Grimberg
2018-06-04  6:31   ` Hannes Reinecke
2018-06-04 11:59   ` Johannes Thumshirn
2018-06-01  7:11 ` [PATCH 4/9] nvme: always failover on path or transport errors Christoph Hellwig
2018-06-01 15:27   ` Mike Snitzer
2018-06-04  6:29     ` Christoph Hellwig
2018-06-04 12:01       ` Johannes Thumshirn
2018-06-04 12:23       ` Mike Snitzer
2018-06-03 12:28   ` Sagi Grimberg
2018-06-04  6:32   ` Hannes Reinecke
2018-06-01  7:11 ` [PATCH 5/9] nvme: add ANA support Christoph Hellwig
2018-06-04  6:36   ` Hannes Reinecke
2018-06-04  7:03     ` Christoph Hellwig
2018-06-04  9:51       ` Hannes Reinecke
2018-06-04 12:31         ` Mike Snitzer
2018-06-04 13:37           ` Hannes Reinecke
2018-06-06 12:01   ` Popuri, Sriram
2018-06-06 12:13     ` Christoph Hellwig
2018-06-06 12:27       ` Popuri, Sriram
2018-06-06 12:50         ` Christoph Hellwig
2018-06-01  7:11 ` [PATCH 6/9] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-06-04  6:35   ` Hannes Reinecke
2018-06-04 12:04   ` Johannes Thumshirn
2018-06-01  7:11 ` [PATCH 7/9] nvmet: add minimal ANA support Christoph Hellwig
2018-06-04  6:41   ` Hannes Reinecke
2018-06-04 12:25   ` Johannes Thumshirn
2018-06-04 12:55     ` Christoph Hellwig
2018-06-01  7:11 ` [PATCH 8/9] nvmet: support configuring additional ANA groups Christoph Hellwig
2018-06-04  6:42   ` Hannes Reinecke
2018-06-04  6:53     ` Christoph Hellwig
2018-06-04  9:48       ` Hannes Reinecke
2018-06-01  7:11 ` [PATCH 9/9] nvmet: make ANATT configurable Christoph Hellwig
2018-06-04 10:21   ` Hannes Reinecke [this message]
2018-06-04 12:11     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604122102.4bfcd154@pentland.suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).