From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs
Date: Tue, 5 Jun 2018 08:37:40 -0600 [thread overview]
Message-ID: <20180605143740.GA10501@localhost.localdomain> (raw)
In-Reply-To: <20180605044733.GA29448@lst.de>
On Tue, Jun 05, 2018@06:47:33AM +0200, Christoph Hellwig wrote:
> But let's assume we don't want to use the list due to this concern:
> we'd still have to read the log page, as per the NVMe spec the only
> think clearing a pending AEN is reading the associated log page.
> We'd then need to still do the full scan using identify. Is this what
> we want? If you think this is important for reliability we could
> just ignore the log page.
That sounds good. Let's have the driver read the log page to re-arm
the event as you've done, but don't rely on the contents for namespace
enumeration.
The rest of your series looks good to me.
next prev parent reply other threads:[~2018-06-05 14:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 10:27 nvme/nvmet AEN and log page fixups Christoph Hellwig
2018-05-26 10:27 ` [PATCH 01/14] block: unexport check_disk_size_change Christoph Hellwig
2018-05-28 6:33 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 02/14] block: don't print a message when the device went away Christoph Hellwig
2018-05-28 6:34 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 03/14] nvme.h: untangle AEN notice definitions Christoph Hellwig
2018-05-28 6:35 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 04/14] nvme.h: add the changed namespace list log Christoph Hellwig
2018-05-28 6:35 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 05/14] nvme.h: add AER configuration symbols Christoph Hellwig
2018-05-28 6:35 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 06/14] nvmet: add a new nvmet_zero_sgl helper Christoph Hellwig
2018-05-28 6:36 ` Johannes Thumshirn
2018-05-29 8:13 ` Christoph Hellwig
2018-05-26 10:27 ` [PATCH 07/14] nvmet: split log page implementation Christoph Hellwig
2018-05-28 6:38 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 08/14] nvmet: implement the changed namespaces log Christoph Hellwig
2018-05-28 6:53 ` Johannes Thumshirn
2018-05-29 8:17 ` Christoph Hellwig
2018-05-29 8:16 ` Johannes Thumshirn
2018-05-29 8:24 ` Christoph Hellwig
2018-05-29 16:59 ` Verkamp, Daniel
2018-05-29 17:24 ` Christoph Hellwig
2018-05-29 20:44 ` Daniel Verkamp
2018-05-26 10:27 ` [PATCH 09/14] nvmet: Add AEN configuration support Christoph Hellwig
2018-05-28 6:54 ` Johannes Thumshirn
2018-05-29 17:15 ` Verkamp, Daniel
2018-05-29 17:29 ` Christoph Hellwig
2018-05-29 17:35 ` Verkamp, Daniel
2018-05-29 17:45 ` Christoph Hellwig
2018-05-26 10:27 ` [PATCH 10/14] nvmet: mask pending AERs Christoph Hellwig
2018-05-28 6:56 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 11/14] nvme: submit AEN event configuration on startup Christoph Hellwig
2018-05-28 6:56 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 12/14] nvme: mark nvme_queue_scan static Christoph Hellwig
2018-05-28 6:57 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs Christoph Hellwig
2018-05-26 12:05 ` Popuri, Sriram
2018-05-26 12:21 ` Christoph Hellwig
2018-05-28 6:59 ` Johannes Thumshirn
2018-06-04 19:59 ` Keith Busch
2018-06-05 4:47 ` Christoph Hellwig
2018-06-05 14:37 ` Keith Busch [this message]
2018-05-26 10:27 ` [PATCH 14/14] nvme: limit warnings from nvme_identify_ns Christoph Hellwig
2018-05-28 7:00 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605143740.GA10501@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).