linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 5/9] nvme: add ANA support
Date: Wed, 6 Jun 2018 14:13:16 +0200	[thread overview]
Message-ID: <20180606121316.GA13227@lst.de> (raw)
In-Reply-To: <BN7PR06MB40333AEEF5E96A05DC6B925592650@BN7PR06MB4033.namprd06.prod.outlook.com>

On Wed, Jun 06, 2018@12:01:04PM +0000, Popuri, Sriram wrote:
> +	ctrl->ana_state = kcalloc(ctrl->anagrpmax, sizeof(*ctrl->ana_state),
> +			GFP_KERNEL);
> 
> You are assuming anagrpmax is a small value. I guess it can go upto ffffffffh.

In theory it could.  In practice that is going to get you very large
data transfers for the ANA log, which we can't chunk.

At some point we might want to look into using the page allocator here,
but for now I'd like to keep it simple.

  reply	other threads:[~2018-06-06 12:13 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01  7:11 draft ANA support v2 Christoph Hellwig
2018-06-01  7:11 ` [PATCH 1/9] nvme: don't hold nvmf_transports_rwsem for more than transport lookups Christoph Hellwig
2018-06-03 12:26   ` Sagi Grimberg
2018-06-04  6:30   ` Hannes Reinecke
2018-06-01  7:11 ` [PATCH 2/9] nvme.h: add ANA definitions Christoph Hellwig
2018-06-03 12:27   ` Sagi Grimberg
2018-06-04  6:30   ` Hannes Reinecke
2018-06-04 11:58   ` Johannes Thumshirn
2018-06-01  7:11 ` [PATCH 3/9] nvme: add support for the log specific field Christoph Hellwig
2018-06-03 12:27   ` Sagi Grimberg
2018-06-04  6:31   ` Hannes Reinecke
2018-06-04 11:59   ` Johannes Thumshirn
2018-06-01  7:11 ` [PATCH 4/9] nvme: always failover on path or transport errors Christoph Hellwig
2018-06-01 15:27   ` Mike Snitzer
2018-06-04  6:29     ` Christoph Hellwig
2018-06-04 12:01       ` Johannes Thumshirn
2018-06-04 12:23       ` Mike Snitzer
2018-06-03 12:28   ` Sagi Grimberg
2018-06-04  6:32   ` Hannes Reinecke
2018-06-01  7:11 ` [PATCH 5/9] nvme: add ANA support Christoph Hellwig
2018-06-04  6:36   ` Hannes Reinecke
2018-06-04  7:03     ` Christoph Hellwig
2018-06-04  9:51       ` Hannes Reinecke
2018-06-04 12:31         ` Mike Snitzer
2018-06-04 13:37           ` Hannes Reinecke
2018-06-06 12:01   ` Popuri, Sriram
2018-06-06 12:13     ` Christoph Hellwig [this message]
2018-06-06 12:27       ` Popuri, Sriram
2018-06-06 12:50         ` Christoph Hellwig
2018-06-01  7:11 ` [PATCH 6/9] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-06-04  6:35   ` Hannes Reinecke
2018-06-04 12:04   ` Johannes Thumshirn
2018-06-01  7:11 ` [PATCH 7/9] nvmet: add minimal ANA support Christoph Hellwig
2018-06-04  6:41   ` Hannes Reinecke
2018-06-04 12:25   ` Johannes Thumshirn
2018-06-04 12:55     ` Christoph Hellwig
2018-06-01  7:11 ` [PATCH 8/9] nvmet: support configuring additional ANA groups Christoph Hellwig
2018-06-04  6:42   ` Hannes Reinecke
2018-06-04  6:53     ` Christoph Hellwig
2018-06-04  9:48       ` Hannes Reinecke
2018-06-01  7:11 ` [PATCH 9/9] nvmet: make ANATT configurable Christoph Hellwig
2018-06-04 10:21   ` Hannes Reinecke
2018-06-04 12:11     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2018-07-24 11:50 draft ANA support v5 Christoph Hellwig
2018-07-24 11:50 ` [PATCH 5/9] nvme: add ANA support Christoph Hellwig
2018-07-26  2:00   ` Martin K. Petersen
2018-07-26 11:34   ` Johannes Thumshirn
2018-07-26 15:34 draft ANA support v6 Christoph Hellwig
2018-07-26 15:35 ` [PATCH 5/9] nvme: add ANA support Christoph Hellwig
2018-07-26 17:20   ` Mike Snitzer
2018-07-27 13:20     ` Hannes Reinecke
2018-07-27 13:38       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606121316.GA13227@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).