From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH] block: always set partition number to '0' in blk_partition_remap()
Date: Wed, 6 Jun 2018 16:22:18 +0200 [thread overview]
Message-ID: <20180606142218.64220-1-hare@suse.de> (raw)
blk_partition_remap() will only clear bi_partno if an actual remapping
has happened. But flush request et al don't have an actual size, so
the remapping doesn't happen and bi_partno is never cleared.
So for stacked devices blk_partition_remap() will be called on each level.
If (as is the case for native nvme multipathing) one of the lower-level
devices do _not_support partitioning a spurious I/O error is generated.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
block/blk-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index cee03cad99f2..8a2c3a474234 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2225,7 +2225,10 @@ static inline int blk_partition_remap(struct bio *bio)
bio->bi_partno = 0;
trace_block_bio_remap(bio->bi_disk->queue, bio, part_devt(p),
bio->bi_iter.bi_sector - p->start_sect);
- }
+ } else
+ /* Set partition number to '0' to avoid repetitive calls */
+ bio->bi_partno = 0;
+
ret = 0;
out:
rcu_read_unlock();
--
2.12.3
next reply other threads:[~2018-06-06 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 14:22 Hannes Reinecke [this message]
2018-06-06 14:26 ` [PATCH] block: always set partition number to '0' in blk_partition_remap() Jens Axboe
2018-06-06 14:36 ` Hannes Reinecke
2018-06-06 14:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606142218.64220-1-hare@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox