From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 10/10] host fold
Date: Wed, 6 Jun 2018 16:33:11 +0200 [thread overview]
Message-ID: <20180606143311.23076-11-hch@lst.de> (raw)
In-Reply-To: <20180606143311.23076-1-hch@lst.de>
---
drivers/nvme/host/multipath.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index d30229a21c97..f88cc4e401c8 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -62,14 +62,16 @@ void nvme_failover_req(struct request *req)
*/
switch (nvme_req(req)->status & 0x7ff) {
case NVME_SC_ANA_TRANSITION:
- /*
- * XXX: We should verify the controller doesn't die on during
- * the transition. But that means we per-group timeout from
- * when we first hit the change state, so this won't be
- * entirely trivial..
- */
- nvme_update_ana_state(ns, NVME_ANA_CHANGE);
+ {
+ enum nvme_ana_state old;
+
+ old = xchg(&ns->ctrl->ana_state[ns->anagrpid], NVME_ANA_CHANGE);
+ if (old != NVME_ANA_CHANGE) {
+ // XXX start timer
+ ;
+ }
break;
+ }
case NVME_SC_ANA_PERSISTENT_LOSS:
nvme_update_ana_state(ns, NVME_ANA_PERSISTENT_LOSS);
break;
@@ -141,7 +143,6 @@ inline struct nvme_ns *nvme_find_path(struct nvme_ns_head *head)
ns = __nvme_find_path(head, NVME_ANA_OPTIMIZED);
if (!ns)
ns = __nvme_find_path(head, NVME_ANA_NONOPTIMIZED);
- /* XXX: try an inaccessible path as last resort per 8.18.3.3 */
return ns;
}
--
2.14.2
next prev parent reply other threads:[~2018-06-06 14:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 14:33 draft ANA support v3 Christoph Hellwig
2018-06-06 14:33 ` [PATCH 01/10] nvme.h: add support for the log specific field Christoph Hellwig
2018-06-07 7:27 ` Johannes Thumshirn
2018-06-07 7:58 ` Hannes Reinecke
2018-06-07 12:34 ` Sagi Grimberg
2018-06-06 14:33 ` [PATCH 02/10] nvme.h: add ANA definitions Christoph Hellwig
2018-06-07 7:59 ` Hannes Reinecke
2018-06-07 8:30 ` Johannes Thumshirn
2018-06-07 12:35 ` Sagi Grimberg
2018-06-06 14:33 ` [PATCH 03/10] nvme: simplify the API for getting log pages Christoph Hellwig
2018-06-07 7:39 ` Johannes Thumshirn
2018-06-07 7:59 ` Hannes Reinecke
2018-06-07 12:35 ` Sagi Grimberg
2018-06-06 14:33 ` [PATCH 04/10] nvme: remove nvme_req_needs_failover Christoph Hellwig
2018-06-07 7:40 ` Johannes Thumshirn
2018-06-07 8:01 ` Hannes Reinecke
2018-06-07 11:57 ` Christoph Hellwig
2018-06-07 12:36 ` Sagi Grimberg
2018-06-06 14:33 ` [PATCH 05/10] nvme: add ANA support Christoph Hellwig
2018-06-07 8:01 ` Hannes Reinecke
2018-06-07 12:49 ` Sagi Grimberg
2018-06-07 13:05 ` Christoph Hellwig
2018-06-07 13:55 ` Christoph Hellwig
2018-06-06 14:33 ` [PATCH 06/10] nvme: don't set gendisks live that don't have an I/O capable path Christoph Hellwig
2018-06-06 14:33 ` [PATCH 07/10] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-06-07 7:54 ` Johannes Thumshirn
2018-06-07 8:02 ` Hannes Reinecke
2018-06-06 14:33 ` [PATCH 08/10] nvmet: add minimal ANA support Christoph Hellwig
2018-06-07 8:03 ` Hannes Reinecke
2018-06-07 12:52 ` Sagi Grimberg
2018-06-06 14:33 ` [PATCH 09/10] nvmet: support configuring ANA groups Christoph Hellwig
2018-06-07 8:09 ` Hannes Reinecke
2018-06-07 12:02 ` Christoph Hellwig
2018-06-07 12:58 ` Sagi Grimberg
2018-06-07 13:08 ` Christoph Hellwig
2018-06-06 14:33 ` Christoph Hellwig [this message]
2018-06-06 14:46 ` [PATCH 10/10] host fold Christoph Hellwig
2018-06-06 15:18 ` Hannes Reinecke
2018-06-07 12:34 ` draft ANA support v3 Sagi Grimberg
2018-06-07 13:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606143311.23076-11-hch@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox