From: hch@lst.de (Christoph Hellwig)
Subject: draft ANA support v4
Date: Mon, 11 Jun 2018 16:11:29 +0200 [thread overview]
Message-ID: <20180611141139.30462-1-hch@lst.de> (raw)
This version has a major update to move the ANA state to struct nvme_ns,
as I did in my original prototypes. I moved away from to handle the
ANA status codes directly, but it turns out that idea is fundamentally
racy anyway.
We'll stell need good nvme-cli and nvmetcli support as well as a lot of
(preferably automated) testing.
A git tree is available at:
git://git.infradead.org/users/hch/block.git nvme-ana
Gitweb:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/nvme-ana
Changes since v3:
- keep the ana state in struct nvme_ns
- don't update the internal ana state based on status codes
- add a ANATT timer (based on code from Hannes Reinecke)
- fix ANA AEN detection, which is missing a OAES bit currently
- make more code conditional on CONFIG_NVME_MULTIPATH
- optimize delayed adding of ns_head gendisks
- only kick of a requeue when setting groups live
- only send AENs on controllers of a port where the group state changes
- a few cleanups to the build-in default group
- fix a use after free in nvme_failover_req (Hannes Reinecke)
Changes since v2:
- support changing the state for the default ANA group
- drop ANATT configuration again
- delay gendisk registration until we have an I/O capable path
- remove nvme_req_needs_failover and the SCT=3 handling in it,
we actually do the right thing without it
- refactor the get log page helpers
Changes since v1:
- fix the check for SCT = 3
- fix the check for immutable ANAGRPID
- disable ANA if the ANA log can't be transferred in a single chunk
- enable the ANA AEN explicitly
- don't zero buffers that don't get copied to the SGL
- use READ_ONCE/WRITE_ONCE for the ana_state fields
- update ANA state on completion with an ANA status code
- improve commit logs
- add proper AEN enable and masking conditionals
- fix the numeric value for the change state
- fix a memory leak (Hannes Reinecke)
- fix reporting of NUSE (based on a patch from Hannes Reinecke)
- make ANATT configurable
next reply other threads:[~2018-06-11 14:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 14:11 Christoph Hellwig [this message]
2018-06-11 14:11 ` [PATCH 01/10] nvme: don't rely on the changed namespace list log Christoph Hellwig
2018-06-12 6:02 ` Hannes Reinecke
2018-06-11 14:11 ` [PATCH 02/10] nvme.h: add support for the log specific field Christoph Hellwig
2018-06-11 14:11 ` [PATCH 03/10] nvme.h: add ANA definitions Christoph Hellwig
2018-06-11 14:11 ` [PATCH 04/10] nvme: simplify the API for getting log pages Christoph Hellwig
2018-06-11 14:11 ` [PATCH 05/10] nvme: remove nvme_req_needs_failover Christoph Hellwig
2018-06-11 14:11 ` [PATCH 06/10] nvme: add ANA support Christoph Hellwig
2018-06-12 8:45 ` Hannes Reinecke
2018-06-13 7:38 ` Christoph Hellwig
2018-06-11 14:11 ` [PATCH 07/10] nvmet: keep a port pointer in nvmet_ctrl Christoph Hellwig
2018-06-12 6:02 ` Hannes Reinecke
2018-06-11 14:11 ` [PATCH 08/10] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-06-11 14:11 ` [PATCH 09/10] nvmet: add minimal ANA support Christoph Hellwig
2018-06-11 14:11 ` [PATCH 10/10] nvmet: support configuring ANA groups Christoph Hellwig
2018-06-12 6:08 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611141139.30462-1-hch@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox