Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: osandov@osandov.com (Omar Sandoval)
Subject: [PATCH V2 06/14] blktests: add fio data verification routine
Date: Mon, 11 Jun 2018 14:09:28 -0700	[thread overview]
Message-ID: <20180611210928.GA25795@vader> (raw)
In-Reply-To: <20180611091554.19639-7-chaitanya.kulkarni@wdc.com>

On Mon, Jun 11, 2018@05:15:46AM -0400, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> ---
>  common/fio | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/common/fio b/common/fio
> index e83258d..abe5ee2 100644
> --- a/common/fio
> +++ b/common/fio
> @@ -162,10 +162,17 @@ _fio_perf() {
>  # tests that should run for a specific amount of time.
>  _run_fio() {
>  	local args=("--output=$TMPDIR/fio_perf" "--output-format=terse" "--terse-version=4" "--group_reporting=1")
> +
>  	if [[ -v TIMEOUT ]]; then
>  		args+=("--runtime=$TIMEOUT")
>  	fi
> +
>  	fio "${args[@]}" "$@"
> +
> +	if [ $? -ne 0 ]; then
> +		echo "error fio failed"
> +		cat "$TMPDIR"/fio_perf
> +	fi

I simplified this to

if ! fio "${args[@]}" "$@"; then
	...
fi

  parent reply	other threads:[~2018-06-11 21:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  9:15 [PATCH V2 00/14] blktests: NVMeOF new testcases for file and bdev ns Chaitanya Kulkarni
2018-06-11  9:15 ` [PATCH V2 01/14] blktests: common/nvme export ns-mgmt interfaces Chaitanya Kulkarni
2018-06-11 11:10   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 02/14] blktests: add NVMeOF bdev-ns target creation test Chaitanya Kulkarni
2018-06-11  9:15 ` [PATCH V2 03/14] blktests: add NVMeOF file-ns " Chaitanya Kulkarni
2018-06-11 11:11   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 04/14] blktests: add NVMeOF bdev-ns host creation Chaitanya Kulkarni
2018-06-11 11:12   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 05/14] blktests: add NVMeOF file-ns " Chaitanya Kulkarni
2018-06-11 11:12   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 06/14] blktests: add fio data verification routine Chaitanya Kulkarni
2018-06-11 11:14   ` Johannes Thumshirn
2018-06-11 21:09   ` Omar Sandoval [this message]
2018-06-12  4:40     ` Chaitanya Kulkarni
2018-06-11  9:15 ` [PATCH V2 07/14] blktests: add NVMeoF data verification test for bdev-ns Chaitanya Kulkarni
2018-06-11 11:23   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 08/14] blktests: add NVMeOF data verification test for file-ns Chaitanya Kulkarni
2018-06-11 11:24   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 09/14] blktests: add NVMeOF mkfs test for bdev-ns Chaitanya Kulkarni
2018-06-11 11:29   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 10/14] blktests: add NVMeOF mkfs test for file-ns Chaitanya Kulkarni
2018-06-11 11:29   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 11/14] blktests: add NVMeOF flush test for bdev-ns Chaitanya Kulkarni
2018-06-11 11:31   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 12/14] blktests: add NVMeOF flush test for file-ns Chaitanya Kulkarni
2018-06-11 11:31   ` Johannes Thumshirn
2018-06-11  9:15 ` [PATCH V2 13/14] blktests: add NVMeOF many bdev-ns creation test Chaitanya Kulkarni
2018-06-11 11:38   ` Johannes Thumshirn
2018-06-11 17:25     ` Chaitanya Kulkarni
2018-06-11  9:15 ` [PATCH V2 14/14] blktests: add NVMeOF many file-ns " Chaitanya Kulkarni
2018-06-11 11:40 ` [PATCH V2 00/14] blktests: NVMeOF new testcases for file and bdev ns Johannes Thumshirn
2018-06-11 22:14 ` Omar Sandoval
2018-06-11 23:14   ` Chaitanya Kulkarni
2018-06-13  0:00   ` Chaitanya Kulkarni
2018-06-13  7:21     ` Johannes Thumshirn
     [not found]       ` <BN6PR04MB120367ABC523F7DDEC83C35A867E0@BN6PR04MB1203.namprd04.prod.outlook.com>
2018-06-25 19:04         ` Omar Sandoval
2018-06-25 19:06           ` Omar Sandoval
2018-06-25 19:16             ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180611210928.GA25795@vader \
    --to=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox