From: hch@infradead.org (Christoph Hellwig)
Subject: [REPOST][PATCH] nvme: move init of keep_alive work item to controller initialization
Date: Wed, 13 Jun 2018 01:10:56 -0700 [thread overview]
Message-ID: <20180613081056.GB7429@infradead.org> (raw)
In-Reply-To: <20180612232824.12379-1-jsmart2021@gmail.com>
On Tue, Jun 12, 2018@04:28:24PM -0700, James Smart wrote:
> Currently, the code initializes the keep alive work item whenever
> nvme_start_keep_alive() is called. However, this routine is called
> several times while reconnecting, etc. Although it's hoped that keep
> alive is always disabled and not scheduled when start is called,
> re-initing if it were scheduled or completing can have very bad
> side effects. There's no need for re-initialization.
>
> Move the keep_alive work item and cmd struct initialization to
> controller init.
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
I don't think this can actually happen, but reducing initialization
is always a good thing. I'll queue it up in the 4.19 tree once that
opens.
prev parent reply other threads:[~2018-06-13 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 23:28 [REPOST][PATCH] nvme: move init of keep_alive work item to controller initialization James Smart
2018-06-13 8:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613081056.GB7429@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox