Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH] nvme-cli: Implemented virtualization management admin command
Date: Fri, 15 Jun 2018 08:21:58 -0600	[thread overview]
Message-ID: <20180615142158.GD8129@localhost.localdomain> (raw)
In-Reply-To: <20180615093732.GD10928@infradead.org>

On Fri, Jun 15, 2018@02:37:32AM -0700, Christoph Hellwig wrote:
> On Thu, Jun 14, 2018@05:24:22PM -0600, Revanth Rajashekar wrote:
> > Signed-off-by: Revanth Rajashekar <revanth.rajashekar at intel.com>
> 
> How has this been tested?  Especially the flexible resource assignments
> really need some kernel support so that the host driver can stop
> using the resources.

I'm not sure this can be sufficiently tested without some prep-patches
adding Identify Primary Controller Capabilities and Identify Secondary
Controler List commands.

But what do we need from the primary controller driver to support this?

Flexible resources assigned to a primary controller are are not
actually used or released until you do a controller reset following your
virtualization management commands, so the driver will automatically
react to the new assignment.

For a secondary controller's flexible resource assignement, you can only
assign flexible resources from the primary controller when the secondary
is offline, so the resources should be discovered by the driver when
the controller is brought online again.

Neither appear to have a requirement for the driver to be aware these
management commands are happening.

      reply	other threads:[~2018-06-15 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 23:24 [PATCH] nvme-cli: Implemented virtualization management admin command Revanth Rajashekar
2018-06-15  9:37 ` Christoph Hellwig
2018-06-15 14:21   ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615142158.GD8129@localhost.localdomain \
    --to=keith.busch@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox