From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Fix error flow at nvme_rdma_configure_admin_queue()
Date: Tue, 19 Jun 2018 07:41:57 +0200 [thread overview]
Message-ID: <20180619054157.GC23184@lst.de> (raw)
In-Reply-To: <a760d739-f88b-99bf-27ca-4dee113b5b49@mellanox.com>
On Sun, Jun 17, 2018@01:52:55PM +0300, Max Gurtovoy wrote:
>> back instead and have a different double free protection. E.g.
>> in nvme_rdma_free_qe just check if qe->data is set first,
>> and the NULL it out when freeing.
>>
>
> I guess we can but this is not enough since we'll need to move the call to
> nvme_rdma_free_qe to be after stopping the queue. I actually think that
> making it symetrical is the right way to go (we also have a flag
> NVME_RDMA_Q_ALLOCATED that helps here) but I guess reverting Sagi's commit
> + some fix will work too.
Yes, it should be symetrical either way. What is the story with
NVME_RDMA_Q_ALLOCATED?
next prev parent reply other threads:[~2018-06-19 5:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 12:37 [PATCH] nvme: Fix error flow at nvme_rdma_configure_admin_queue() Israel Rukshin
2018-06-15 8:01 ` Christoph Hellwig
2018-06-17 10:52 ` Max Gurtovoy
2018-06-19 5:41 ` Christoph Hellwig [this message]
2018-06-19 10:36 ` Sagi Grimberg
2018-06-19 12:09 ` Max Gurtovoy
2018-06-19 12:30 ` Sagi Grimberg
2018-06-19 16:08 ` Max Gurtovoy
2018-06-19 16:12 ` Sagi Grimberg
2018-06-19 16:21 ` Max Gurtovoy
2018-06-19 16:38 ` Sagi Grimberg
2018-06-19 11:57 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619054157.GC23184@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox