From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/7] nvme-rdma: fix possible double free condition when failing to create a controller
Date: Wed, 20 Jun 2018 14:29:34 +0200 [thread overview]
Message-ID: <20180620122934.GB13858@lst.de> (raw)
In-Reply-To: <be2a572c-6e6e-8a1c-608e-457fbd8cb01b@grimberg.me>
On Wed, Jun 20, 2018@01:41:29PM +0300, Sagi Grimberg wrote:
>> can you explain this error flow ? we'll never free the queues since the
>> list &ctrl->list is empty. I guess a fix to nvme_rdma_free_ctrl is needed
>> in this case.
>
> Good catch! I lost this in the rebase:
Thanks, folded.
next prev parent reply other threads:[~2018-06-20 12:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 12:34 [PATCH 0/7] few nvme-rdma fixes for 4.18 Sagi Grimberg
2018-06-19 12:34 ` [PATCH 1/7] nvme-rdma: fix possible double free condition when failing to create a controller Sagi Grimberg
2018-06-20 9:06 ` Max Gurtovoy
2018-06-20 10:41 ` Sagi Grimberg
2018-06-20 12:29 ` Christoph Hellwig [this message]
2018-06-19 12:34 ` [PATCH 2/7] nvme-rdma: fix possible free non-allocated async event buffer Sagi Grimberg
2018-06-20 8:31 ` Christoph Hellwig
2018-06-20 12:02 ` Max Gurtovoy
2018-06-24 10:40 ` [Suspected-Phishing]Re: " Max Gurtovoy
2018-06-24 16:00 ` Sagi Grimberg
2018-06-24 16:19 ` Max Gurtovoy
2018-06-19 12:34 ` [PATCH 3/7] nvme-rdma: Fix command completion race at error recovery Sagi Grimberg
2018-06-19 12:34 ` [PATCH 4/7] nvme-rdma: unquiesce queues when deleting the controller Sagi Grimberg
2018-06-21 9:57 ` Max Gurtovoy
2018-06-24 16:07 ` Sagi Grimberg
2018-06-19 12:34 ` [PATCH 5/7] nvme-rdma: don't override opts->queue_size Sagi Grimberg
2018-06-19 16:56 ` Daniel Verkamp
2018-06-19 12:34 ` [PATCH 6/7] nvme-rdma: centralize controller setup sequence Sagi Grimberg
2018-06-19 12:34 ` [PATCH 7/7] nvme-rdma: centralize admin/io queue teardown sequence Sagi Grimberg
2018-06-20 8:40 ` [PATCH 0/7] few nvme-rdma fixes for 4.18 Christoph Hellwig
2018-06-20 8:40 ` Sagi Grimberg
2018-06-20 8:52 ` Christoph Hellwig
2018-06-20 8:53 ` Sagi Grimberg
2018-06-20 9:05 ` Christoph Hellwig
2018-06-20 9:08 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620122934.GB13858@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox