From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH] nvme: trace: add disk name to tracepoints
Date: Tue, 26 Jun 2018 09:01:06 -0600 [thread overview]
Message-ID: <20180626150106.GB6628@localhost.localdomain> (raw)
In-Reply-To: <20180626135141.14088-3-jthumshirn@suse.de>
On Tue, Jun 26, 2018@03:51:41PM +0200, Johannes Thumshirn wrote:
> @@ -655,9 +655,9 @@ blk_status_t nvme_setup_cmd(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> cmd->common.command_id = req->tag;
> nvme_req(req)->ctrl = ctrl;
> if (ns)
> - trace_nvme_setup_nvm_cmd(req->q->id, cmd);
> + trace_nvme_setup_nvm_cmd(req, cmd, ns->disk->disk_name);
Not related to your patch, but I did notice that the req->q->id isn't
really useful here since that's not the hardware context identifier.
That's just some ida assigned software identifier. For the admin command
completion trace, it's actually a little confusing to see the qid in the
trace.
next prev parent reply other threads:[~2018-06-26 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:51 [PATCH v4 0/2] nvme: add controller id and disk name to tracepoints Johannes Thumshirn
2018-06-26 13:51 ` [PATCH v4 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request Johannes Thumshirn
2018-06-26 14:55 ` Keith Busch
2018-06-27 7:35 ` Johannes Thumshirn
2018-06-27 8:45 ` Sagi Grimberg
2018-06-26 13:51 ` [PATCH] nvme: trace: add disk name to tracepoints Johannes Thumshirn
2018-06-26 15:01 ` Keith Busch [this message]
2018-06-27 7:33 ` Johannes Thumshirn
2018-06-27 8:06 ` Sagi Grimberg
2018-06-27 10:00 ` Johannes Thumshirn
2018-06-27 23:43 ` Keith Busch
2018-06-28 0:59 ` Keith Busch
2018-06-28 7:44 ` Johannes Thumshirn
2018-06-28 14:34 ` Sagi Grimberg
2018-06-28 15:02 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2018-05-30 13:20 Johannes Thumshirn
2018-05-30 23:06 ` Sagi Grimberg
2018-05-31 16:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626150106.GB6628@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox