From: keith.busch@linux.intel.com (Keith Busch)
Subject: Fwd: [PATCH] nvme-cli : fix offset advance in nvme-ioctl.c: nvme_get_properties()
Date: Wed, 27 Jun 2018 12:08:32 -0600 [thread overview]
Message-ID: <20180627180832.GC9361@localhost.localdomain> (raw)
In-Reply-To: <CAPrnrPCVggtMCzHdNm4wmtYUzTx2bnqYGyT2shHzq+0tRyL19w@mail.gmail.com>
On Wed, Jun 27, 2018@08:57:16PM +0300, Eyal BenDavid wrote:
> Resend:
>
> diff --git i/nvme-ioctl.c w/nvme-ioctl.c
> index f1c7ce6..2e0abf9 100644
> --- i/nvme-ioctl.c
> +++ w/nvme-ioctl.c
> @@ -578,8 +578,10 @@ int nvme_get_properties(int fd, void **pbar)
> continue;
> }
> ret = 0;
> - if (is64bit)
> + if (is64bit) {
> *(uint64_t *)(*pbar + off) = le64_to_cpu(value64);
> + off += 4;
> + }
> else
> *(uint32_t *)(*pbar + off) = le32_to_cpu(value64);
> }
The diff is still mangled and doesn't apply.
prev parent reply other threads:[~2018-06-27 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 7:37 [PATCH] nvme-cli : fix offset advance in nvme-ioctl.c: nvme_get_properties() Eyal BenDavid
2018-06-27 17:34 ` Fwd: " Eyal BenDavid
2018-06-27 17:42 ` Keith Busch
2018-06-27 17:57 ` Eyal BenDavid
2018-06-27 18:08 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627180832.GC9361@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox