From mboxrd@z Thu Jan  1 00:00:00 1970
From: keith.busch@linux.intel.com (Keith Busch)
Date: Mon, 2 Jul 2018 08:49:01 -0600
Subject: [PATCHv4 2/4] nvme: use hw qid in trace events
In-Reply-To: <20180702131107.GB4624@lst.de>
References: <20180629225003.16567-1-keith.busch@intel.com>
 <20180629225003.16567-3-keith.busch@intel.com>
 <20180702131107.GB4624@lst.de>
Message-ID: <20180702144900.GA22806@localhost.localdomain>

On Mon, Jul 02, 2018@03:11:08PM +0200, Christoph Hellwig wrote:
> > diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h
> > index 01390f0e1671..6f9ee5fe5e09 100644
> > --- a/drivers/nvme/host/trace.h
> > +++ b/drivers/nvme/host/trace.h
> > @@ -24,6 +24,15 @@
> >  
> >  #include "nvme.h"
> >  
> > +#define __assign_nvme_qid(req, qid)					\
> > +	do {								\
> > +		if (req->rq_disk)					\
> > +			qid = 1 + blk_mq_unique_tag_to_hwq(		\
> > +					blk_mq_unique_tag(req));	\
> > +		else							\
> > +			qid = 0;					\
> > +	} while (0)
> 
> Why can't we use an inline function for this?
> 
> Relying on assining to macro paramters is a good way to generate
> unreadable code.

Sure, I can respin these as inline functions.