From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH rfc 0/2] nvmet nice logging helpers
Date: Mon, 16 Jul 2018 13:53:41 +0300 [thread overview]
Message-ID: <20180716105343.29699-1-sagi@grimberg.me> (raw)
This patch set adds some friendly logging helpers with similar
functionality to dev_[err|warn|info|dbg]. When building a
target system with multiple ports and multiple controllers
connected, its useful to have a coherent log message formats
that provide the affected port and controller identifier.
The one annoying thing is that for xxxx_dbg helper I needed
to open-code the dynamic debug macros. If anyone has a better
idea on how to have it, it'd be great (without allocating a class
device for it).
Feedback is welcome.
Sagi Grimberg (2):
nvmet: add nvmet port logging helpers
nvmet: add nvmet ctrl logging helpers
drivers/nvme/target/admin-cmd.c | 11 ++++-----
drivers/nvme/target/configfs.c | 37 +++++++++++-----------------
drivers/nvme/target/core.c | 20 +++++++--------
drivers/nvme/target/discovery.c | 13 +++++-----
drivers/nvme/target/fabrics-cmd.c | 15 +++++------
drivers/nvme/target/io-cmd-bdev.c | 5 ++--
drivers/nvme/target/nvmet.h | 44 +++++++++++++++++++++++++++++++++
drivers/nvme/target/rdma.c | 52 ++++++++++++++++++++++-----------------
8 files changed, 122 insertions(+), 75 deletions(-)
--
2.14.1
next reply other threads:[~2018-07-16 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:53 Sagi Grimberg [this message]
2018-07-16 10:53 ` [PATCH rfc 1/2] nvmet: add nvmet port logging helpers Sagi Grimberg
2018-07-16 10:53 ` [PATCH rfc 2/2] nvmet: add nvmet ctrl " Sagi Grimberg
2018-07-16 22:11 ` Chaitanya Kulkarni
2018-07-18 12:25 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716105343.29699-1-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).