From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH 1/5] nvme: count all ANA groups for ANA Log page
Date: Mon, 16 Jul 2018 12:58:33 +0200 [thread overview]
Message-ID: <20180716105837.101125-2-hare@suse.de> (raw)
In-Reply-To: <20180716105837.101125-1-hare@suse.de>
When issuing a short read on the ANA log page the number of groups
should not change, even though the final returned data might contain
less groups than that number.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
drivers/nvme/target/admin-cmd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 8de264ece826..92682ed11bc4 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -200,6 +200,11 @@ static void nvmet_execute_get_log_page_ana(struct nvmet_req *req)
offset += len;
ngrps++;
}
+ while (grpid <= NVMET_MAX_ANAGRPS) {
+ if (nvmet_ana_group_enabled[grpid])
+ ngrps++;
+ grpid++;
+ }
hdr.chgcnt = cpu_to_le64(nvmet_ana_chgcnt);
hdr.ngrps = cpu_to_le16(ngrps);
--
2.12.3
next prev parent reply other threads:[~2018-07-16 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:58 [PATCH 0/5] nvme: ANA implementation fixes Hannes Reinecke
2018-07-16 10:58 ` Hannes Reinecke [this message]
2018-07-19 14:31 ` [PATCH 1/5] nvme: count all ANA groups for ANA Log page Christoph Hellwig
2018-09-17 13:49 ` Christoph Hellwig
2018-07-16 10:58 ` [PATCH 2/5] nvmet: fixup crash on NULL device path Hannes Reinecke
2018-07-17 13:48 ` Christoph Hellwig
2018-07-17 13:48 ` Hannes Reinecke
2018-07-17 13:55 ` Christoph Hellwig
2018-07-24 14:02 ` Christoph Hellwig
2018-07-25 7:25 ` Hannes Reinecke
2018-07-16 10:58 ` [PATCH 3/5] nvme-multipath: fixup crash during disconnect Hannes Reinecke
2018-07-19 14:31 ` Christoph Hellwig
2018-07-19 14:35 ` Christoph Hellwig
2018-07-16 10:58 ` [PATCH 4/5] nvme-multipath: disable ANA support if parsing fails Hannes Reinecke
2018-07-19 14:43 ` Christoph Hellwig
2018-07-19 16:00 ` Hannes Reinecke
2018-07-20 15:00 ` Christoph Hellwig
2018-07-16 10:58 ` [PATCH 5/5] nvme-multipath: parse entire ANA log page in nvme_set_ns_ana_state() Hannes Reinecke
2018-07-19 14:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716105837.101125-2-hare@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).