linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCHv4 2/4] nvme: Start controller in own work queue
Date: Mon, 16 Jul 2018 09:35:41 -0600	[thread overview]
Message-ID: <20180716153540.GA26265@localhost.localdomain> (raw)
In-Reply-To: <7647e947-f20c-a0eb-d4b5-f19748e2b4bd@grimberg.me>

On Mon, Jul 16, 2018@06:00:38PM +0300, Sagi Grimberg wrote:
> 
> > This moves the controller start from the reset_work to its own work.
> > This is preparing for the possibility of running IO when starting the
> > controller, which we shouldn't do from the reset_work since we need that
> > context to handle timeouts.
> 
> What do you mean handle timeouts? the timeout handler is not invoked
> from the reset_work thread.

Not directly. If you dispatch blocking IO from the reset_work, the timeout
handler will eventually be invoked if the IO never returns. This series
is really just trying to get all the blocking IO out of the reset_work
because IO may requeue when the timeout handler disables the controller,
and we need the reset_work to restart the controller.

  reply	other threads:[~2018-07-16 15:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 20:56 [PATCHv4 0/4] nvme timeout updates Keith Busch
2018-07-13 20:56 ` [PATCHv4 1/4] nvme: Sync request queues on reset Keith Busch
2018-07-16  8:52   ` jianchao.wang
2018-07-16 10:39     ` Ming Lei
2018-07-16 13:30       ` Keith Busch
2018-07-17  5:37         ` jianchao.wang
2018-07-16 14:51   ` Sagi Grimberg
2018-07-16 15:37     ` Keith Busch
2018-07-16 16:36       ` Sagi Grimberg
2018-07-16 17:12         ` Keith Busch
2018-07-17 13:40           ` Christoph Hellwig
2018-07-17 14:54             ` Keith Busch
2018-07-18 11:46           ` Sagi Grimberg
2018-07-18 13:52             ` Keith Busch
2018-07-13 20:56 ` [PATCHv4 2/4] nvme: Start controller in own work queue Keith Busch
2018-07-16 15:00   ` Sagi Grimberg
2018-07-16 15:35     ` Keith Busch [this message]
2018-07-13 20:56 ` [PATCHv4 3/4] nvme: Introduce frozen controller state Keith Busch
2018-07-16  9:02   ` jianchao.wang
2018-07-16 11:09   ` Ming Lei
2018-07-16 13:36     ` Keith Busch
2018-07-17  1:23       ` Ming Lei
2018-07-17  5:49         ` jianchao.wang
2018-07-17  7:21           ` Ming Lei
2018-07-17  7:28             ` jianchao.wang
2018-07-17 14:32               ` Keith Busch
2018-07-18  2:57                 ` jianchao.wang
2018-07-17 14:06         ` Keith Busch
2018-07-16 16:34   ` Sagi Grimberg
2018-07-17 16:05     ` James Smart
2018-07-17 16:17       ` Keith Busch
2018-07-18 12:20         ` Sagi Grimberg
2018-07-18 13:53           ` Keith Busch
2018-07-13 20:56 ` [PATCHv4 4/4] nvme-pci: Use controller start work to dispath IO Keith Busch
2018-07-19 19:48 ` [PATCHv4 0/4] nvme timeout updates Scott Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716153540.GA26265@localhost.localdomain \
    --to=keith.busch@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).